Fix: FindVirtualTable gives RTTI instead of entrypoint #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlynxCZ
changed the title
SlynxCZ
changed the title
Poggicek
reviewed
Oct 22, 2025
|
Yeah and double checked, before logic was correct. Thank you for correcting me @Poggicek ! |
|
Then I will create one more commit that fixes hash naming for API. That is all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is fix of FindVirtualTable method exposed to NativeAPI, Issue was that I accidentally used method from CModule to fetch vtable. I trought this method works same as DynLibUtils GetVirtualTableByName (nope it didnt :D). Method from CModule did gave pointer to vtables RTTI, this is wrong, it should give vtable entrypoint, as getting entrypoint from RTTI in C# is painful and sometimes caused me crashes when debugging with AcceleratorCSS. This is now fixed thanks to 2 new helper methods in memory.cpp👍