-
-
Notifications
You must be signed in to change notification settings - Fork 191
ConVar flags that adapts to different Source 2 SDK versions #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix new Debian and Ubuntu version and Stop Leak
Contributor
Author
Fix new Debian and Ubuntu version, Stop Leak and Code format checks / Lint code with clang-format
Contributor
Author
|
Please run the workflow again and check whether everything has been written and adjusted correctly. I have now followed the guidelines and made this adjustment. The change is currently compatible with the new update as well as the old Linux version |
roflmuffin
approved these changes
Oct 18, 2025
This was referenced Oct 20, 2025
Closed
Closed
This was referenced Oct 27, 2025
Closed
This was referenced Oct 27, 2025
Closed
Closed
Closed
This was referenced Nov 5, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section introduces a compatibility layer for setting ConVar flags that adapts to different Source 2 SDK versions.
Older and newer SDK builds expose slightly different APIs for modifying ConVar flags (AddFlags, ClearFlags, RemoveFlags, or SetFlag).
To ensure compatibility across these versions, the new implementation detects at compile time which API is available and uses it automatically.
The concept definitions check whether the ConVar type provides specific flag functions:
HasAddClear: uses AddFlags() and ClearFlags()
HasAddRemove: uses AddFlags() and RemoveFlags()
HasSetFlagBit: uses SetFlag(bit, bool)
The SetAllFlagsCompat function then compares the current flags with the desired ones and applies the correct operations:
Adds or clears bits using whichever API the SDK exposes.
Falls back to setting individual bits if only SetFlag() is available.
This change is required for the current Source 2 SDK,
as the internal ConVar implementation and flag management functions have changed between builds.
The new logic ensures consistent behavior without relying on private members such as m_nFlags,
making the code safer, forward-compatible, and SDK-agnostic.
💬 In short:
This update introduces a flexible flag-handling mechanism required by the latest Source 2 SDK to remain compatible with internal API changes and to avoid direct access to private ConVar data.