-
-
Notifications
You must be signed in to change notification settings - Fork 191
feat: Implement TerminateSelf(string reason) to allow plugins to safely terminate themselves
#1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Nothing 😪 |
Contributor
Author
Contributor
Author
Contributor
Author
|
Nothing 😪 |
…handling exceptions
Contributor
Author
|
Well, we successfully solved the Silent Execution Termination problem in commit ba6a8b7
|
Contributor
Author
Contributor
Author
Contributor
Author
|
@roflmuffin |
roflmuffin
approved these changes
Oct 17, 2025
This was referenced Oct 20, 2025
Closed
Closed
This was referenced Oct 20, 2025
Closed
This was referenced Oct 27, 2025
Closed
Closed
Closed
This was referenced Nov 5, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.










Prior to implementing
TerminateSelf, plugins could only prevent initialization by throwing exceptions within their Load() override method. Once fully loaded, however, plugins lacked any elegant mechanism for self-terminationSo, we implemented a state-aware TerminateSelf method:
try-catch)btw. Rather than injecting the complete
PluginContextintoBasePlugin(which would enable dangerous control inversion allowing plugins to manipulate framework internals or other plugin instances), we employed interface segregation by introducingISelfPluginControl. This restricted interface exposes only self-termination capabilities to plugins, 100% adhering to the principle of least privilege and preventing unauthorized access to framework components or cross-plugin manipulation 🤗