Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return cmd output on error #7

Closed
stevanmilic opened this issue Sep 13, 2023 · 2 comments · Fixed by #8
Closed

Return cmd output on error #7

stevanmilic opened this issue Sep 13, 2023 · 2 comments · Fixed by #8

Comments

@stevanmilic
Copy link
Contributor

stevanmilic commented Sep 13, 2023 •
edited
Loading

Hi, thanks for this nice utility!

Is it possible to exit the wait-for-it program with error exit code in case underlying command returns an error? Doing so would indicate the command we were waiting for has failed, and that we need to address it somehow.

I can submit a PR for this, if this is acceptable behavior.
stevanmilic added a commit to stevanmilic/wait-for-it that referenced this issue Sep 23, 2023
@stevanmilic
feat: return subcommand's exit code on execute (roerohan#7)
ed4a7b8
@stevanmilic stevanmilic mentioned this issue Sep 23, 2023
Merged
@stevanmilic
Copy link
Contributor Author

@roerohan I've made a PR for this #8, please take a look when you got the time, thanks!

@roerohan
Copy link
Owner

roerohan commented Sep 24, 2023 •
edited
Loading

Hi @stevanmilic

Thanks for contributing! I'll take a look at the PR and leave a review (and get it merged as well!)

Update:

I've merged the PR

roerohan added a commit that referenced this issue Sep 24, 2023
@roerohan
Merge pull request #8 from stevanmilic/main
3d4b9e5 
feat: return subcommand's exit code on execute (#7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: return subcommand's exit code on execute (#7) stevanmilic/wait-for-it
2 participants
@stevanmilic @roerohan