Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abi_stable::sabi_trait triggering repr_transparent_external_private_fields warning with latest nightly rustc #94

Closed
zirconium-n opened this issue Aug 8, 2022 · 3 comments · Fixed by #96

Comments

@zirconium-n
Copy link

After upgrading my rustc to rustc 1.65.0-nightly (2befdefdd 2022-08-06), following warning appeared and I think it should be fixed.

   |
60 | #[abi_stable::sabi_trait]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(repr_transparent_external_private_fields)]` on by default
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #78586 <https://github.com/rust-lang/rust/issues/78586>
   = note: this struct contains `UnsafeIgnoredType<SyncSend>`, which contains private fields, and makes it not a breaking change to become non-zero-sized in the future.
   = note: this warning originates in the attribute macro `abi_stable::sabi_trait` (in Nightly builds, run with -Z macro-backtrace for more info)
@zirconium-n
Copy link
Author

rust-lang/rust#78586

@zirconium-n zirconium-n changed the title abi_stable::sabi_trait triggering repr_transparent_external_private_fields warning in latest nightly rustc abi_stable::sabi_trait triggering repr_transparent_external_private_fields warning with latest nightly rustc Aug 8, 2022
@afranchuk
Copy link
Contributor

Note this is now also present in 1.64.0 (stable).

@jcrevier
Copy link

@rodrimati1992 To what degree does abi_stable depend on this behavior? Can this warning be fixed in a non-breaking change to stable_abi?

afranchuk added a commit to afranchuk/abi_stable_crates that referenced this issue Nov 3, 2022
afranchuk added a commit to afranchuk/abi_stable_crates that referenced this issue Nov 3, 2022
rodrimati1992 pushed a commit that referenced this issue Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants