Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot-fix #2355

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Snapshot-fix #2355

merged 1 commit into from
Dec 16, 2024

Conversation

rodent1
Copy link
Owner

@rodent1 rodent1 commented Dec 16, 2024

From onedr0p: So the snapshot-controller v4 update doesn't work with rook-ceph due the group CRDs going from v1alpha1 to v1beta1

To revert:

k delete crd volumegroupsnapshotclasses.groupsnapshot.storage.k8s.io volumegroupsnapshotcontents.groupsnapshot.storage.k8s.io volumegroupsnapshots.groupsnapshot.storage.k8s.io

then commit the old version back to 3.0.6

@ro-bott ro-bott bot added area/kubernetes Changes made in the kubernetes directory cluster/main labels Dec 16, 2024
@ro-bott
Copy link
Contributor

ro-bott bot commented Dec 16, 2024

--- kubernetes/main/apps/volsync-system/snapshot-controller/app Kustomization: flux-system/snapshot-controller HelmRelease: volsync-system/snapshot-controller

+++ kubernetes/main/apps/volsync-system/snapshot-controller/app Kustomization: flux-system/snapshot-controller HelmRelease: volsync-system/snapshot-controller

@@ -13,13 +13,13 @@

     spec:
       chart: snapshot-controller
       sourceRef:
         kind: HelmRepository
         name: piraeus
         namespace: flux-system
-      version: 4.0.0
+      version: 3.0.6
   install:
     crds: CreateReplace
     remediation:
       retries: 3
   interval: 30m
   upgrade:
@@ -30,7 +30,9 @@

       strategy: rollback
   values:
     controller:
       replicaCount: 2
       serviceMonitor:
         create: true
+    webhook:
+      enabled: false
 

@ro-bott
Copy link
Contributor

ro-bott bot commented Dec 16, 2024

--- HelmRelease: volsync-system/snapshot-controller ClusterRole: volsync-system/snapshot-controller

+++ HelmRelease: volsync-system/snapshot-controller ClusterRole: volsync-system/snapshot-controller

@@ -59,13 +59,12 @@

   - patch
 - apiGroups:
   - snapshot.storage.k8s.io
   resources:
   - volumesnapshots
   verbs:
-  - create
   - get
   - list
   - watch
   - update
   - patch
   - delete
--- HelmRelease: volsync-system/snapshot-controller Deployment: volsync-system/snapshot-controller

+++ HelmRelease: volsync-system/snapshot-controller Deployment: volsync-system/snapshot-controller

@@ -28,13 +28,13 @@

           capabilities:
             drop:
             - ALL
           readOnlyRootFilesystem: true
           runAsNonRoot: true
           runAsUser: 1000
-        image: registry.k8s.io/sig-storage/snapshot-controller:v8.2.0
+        image: registry.k8s.io/sig-storage/snapshot-controller:v8.1.0
         imagePullPolicy: IfNotPresent
         args:
         - --http-endpoint=:8080
         - --leader-election=true
         - --leader-election-namespace=$(NAMESPACE)
         ports:

@rodent1 rodent1 merged commit f453b12 into main Dec 16, 2024
10 checks passed
@rodent1 rodent1 deleted the snapshot-fix branch December 16, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes Changes made in the kubernetes directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant