Skip to content

Improve warning for nonuniform coercions#17713

Closed
proux01 wants to merge 1 commit intorocq-prover:masterfrom
proux01:advertize_nonuniform_opt
Closed

Improve warning for nonuniform coercions#17713
proux01 wants to merge 1 commit intorocq-prover:masterfrom
proux01:advertize_nonuniform_opt

Conversation

@proux01
Copy link
Contributor

@proux01 proux01 commented Jun 9, 2023

So as to better advertize the attribute introduced in #15853

  • Added / updated test-suite.
  • Added changelog.
  • Added / updated documentation.
    • Documented any new / changed user messages.
    • Updated documented syntax by running make doc_gram_rsts.
  • Opened overlay pull requests.

@proux01 proux01 added kind: user messages Error messages, warnings, etc. kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. labels Jun 9, 2023
@proux01 proux01 requested review from a team as code owners June 9, 2023 11:11
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jun 9, 2023
@Alizter
Copy link
Contributor

Alizter commented Jun 9, 2023

Actually what's the point of the #[nonuniform] attribute now that we can silence specific warnings using attributes?

@SkySkimmer SkySkimmer requested review from a team and removed request for a team June 9, 2023 11:44
@proux01
Copy link
Contributor Author

proux01 commented Jun 9, 2023

Good point! So let me open another PR deprecating the nonuniform attribute and advertizing the use of the warning attribute introduced in 8.18 by #16902 and let's close the current PR.

@proux01 proux01 closed this Jun 9, 2023
@proux01 proux01 deleted the advertize_nonuniform_opt branch June 9, 2023 11:52
@proux01 proux01 mentioned this pull request Jun 9, 2023
8 tasks
@jfehrle
Copy link
Member

jfehrle commented Jun 9, 2023

FWIW the correct spellings are "advertise" and "advertising".

@proux01
Copy link
Contributor Author

proux01 commented Jun 9, 2023

FWIW the correct spellings are "advertise" and "advertising".

Thanks, I guess I tried to look overly american ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. kind: user messages Error messages, warnings, etc. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants