Skip to content

[leminv] [declare] Use higher-level Declare API.#12610

Merged
ppedrot merged 2 commits intorocq-prover:masterfrom
ejgallego:proof+leminv_ref
Sep 18, 2020
Merged

[leminv] [declare] Use higher-level Declare API.#12610
ppedrot merged 2 commits intorocq-prover:masterfrom
ejgallego:proof+leminv_ref

Conversation

@ejgallego
Copy link
Contributor

Nit on using the higher-level API + bugfix for Derive API.

@ejgallego ejgallego requested review from a team as code owners June 30, 2020 12:30
@ejgallego ejgallego added the kind: internal API, ML documentation... label Jun 30, 2020
add_inversion_lemma ~poly na env sigma c sort bool tac
with
| UserError (Some "Case analysis",s) -> (* Reference to Indrec *)
user_err ~hdr:"Inv needs Nodep Prop Set" s
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this was dead code.

@coqbot
Copy link
Contributor

coqbot commented Jun 30, 2020

For your complete information, the following job in allow failure mode has failed: test-suite:4.12+trunk+dune

@coqbot
Copy link
Contributor

coqbot commented Jun 30, 2020

For your complete information, the following job in allow failure mode has failed: test-suite:4.11+trunk+dune

@coqbot
Copy link
Contributor

coqbot commented Jun 30, 2020

For your complete information, the following job in allow failure mode has failed: test-suite:base+async

@ejgallego ejgallego added the needs: fixing The proposed code change is broken. label Jun 30, 2020
@SkySkimmer
Copy link
Contributor

check_evars_are_solved is too strict, we only care about the evars in the current definition.

@SkySkimmer
Copy link
Contributor

May work after #12759, at least the test for #2775 is fixed when I tried merging the 2 PRs.

@ejgallego
Copy link
Contributor Author

May work after #12759, at least the test for #2775 is fixed when I tried merging the 2 PRs.

Let's see :)

@SkySkimmer SkySkimmer self-requested a review August 31, 2020 11:33
@SkySkimmer SkySkimmer removed the needs: fixing The proposed code change is broken. label Aug 31, 2020
@ppedrot ppedrot self-assigned this Sep 15, 2020
@ppedrot
Copy link
Member

ppedrot commented Sep 17, 2020

Anybody understanding the errors spitted by coq_tools?

@ejgallego
Copy link
Contributor Author

Anybody understanding the errors spitted by coq_tools?

Spurious / unrelated so far, let's rerun just in case.

@ppedrot ppedrot added this to the 8.13+beta1 milestone Sep 18, 2020
@ppedrot ppedrot merged commit ff508ba into rocq-prover:master Sep 18, 2020
@ejgallego ejgallego deleted the proof+leminv_ref branch September 18, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: internal API, ML documentation...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants