-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix auto minimizer to download all dependencies #333
Conversation
Do we not have CI to check that it compiles? I don't have the bot dependencies installed right now so I was coding without compiling. |
Indeed, we don't. We could certainly adapt the current CI for master to also run on branch, but by making the final deploy step require a specific click on a button. It would be better than the current setup, where I push to my fork to test-deploy PRs. I have pushed a commit fixing blindly the compilation. Please review my changes, and if you are happy with them, I can test-deploy the PR for further debugging. |
Updated, should be ready to test |
Deployment in progress: https://github.com/Zimmi48/bot/actions/runs/12906685354 |
I guess we won't be able to test the minimizer immediately since it needs a master pipeline with the updated message in checks. EDIT: or does it? I'm not sure. |
I got the old style check message in https://github.com/coq/coq/pull/20101/checks?check_run_id=35989807584 |
I don't think you pushed the right commit, the actions link you gave says "Zimmi48 pushed fba784b" |
Arf, really sorry about that. It looks like I'm forgetting how to use git 😆 |
The regex was incorrect, please redeploy |
This part seems to work, there are more fixes needed for unrelated reasons but this PR should be good to merge. |
No description provided.