Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name to sportsipy #536

Merged
merged 1 commit into from
Jan 1, 2021
Merged

Change name to sportsipy #536

merged 1 commit into from
Jan 1, 2021

Conversation

roclark
Copy link
Owner

@roclark roclark commented Nov 13, 2020

To avoid confusion from users of the sports-reference website, this project needs to be renamed to something other than sportsreference, indicating it is not an official project.

Fixes #497

Signed-Off-By: Robert Clark [email protected]

@roclark roclark added documentation An update to the documentation is needed quality of life Any updates that improve the overall quality of the code labels Nov 13, 2020
@roclark roclark added this to the Release 0.6.0 milestone Nov 13, 2020
@roclark roclark self-assigned this Nov 13, 2020
@roclark roclark force-pushed the change-name branch 2 times, most recently from 6952dab to c0b2afa Compare November 13, 2020 22:45
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #536 (e5f8646) into master (22a45ea) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          55       55           
  Lines       13178    13178           
=======================================
  Hits        13175    13175           
  Misses          3        3           
Impacted Files Coverage Δ
sportsipy/decorators.py 100.00% <ø> (ø)
sportsipy/fb/constants.py 100.00% <ø> (ø)
sportsipy/fb/fb_utils.py 100.00% <ø> (ø)
sportsipy/fb/league_ids.py 100.00% <ø> (ø)
sportsipy/fb/squad_ids.py 100.00% <ø> (ø)
sportsipy/fb/team.py 100.00% <ø> (ø)
sportsipy/mlb/boxscore.py 100.00% <ø> (ø)
sportsipy/mlb/constants.py 100.00% <ø> (ø)
sportsipy/mlb/player.py 100.00% <ø> (ø)
sportsipy/mlb/roster.py 100.00% <ø> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a45ea...e5f8646. Read the comment docs.

To avoid confusion from users of the sports-reference website, this
project needs to be renamed to something other than sportsreference,
indicating it is not an official project.

Signed-Off-By: Robert Clark <[email protected]>
@roclark roclark merged commit 8fed6ad into master Jan 1, 2021
@roclark roclark deleted the change-name branch January 1, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation An update to the documentation is needed quality of life Any updates that improve the overall quality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The title of the project is causing confusion among our users.
1 participant