Update default values for NBA players #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where no information is present for an NBA player, the default value of None should be used for all attributes. At present, the code was unable to initialize many default common variables for players, which resulted in an error while trying to pull data from the Roster class. Signed-Off-By: Robert Clark <[email protected]>
roclark
force-pushed
the
fix-nba-missing-player-data
branch
from
f151a47 to
a77d96f
Compare
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 55 55
Lines 13106 13108 +2
=======================================
+ Hits 13103 13105 +2
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where no information is present for an NBA player, the default value of
Noneshould be used for all attributes. At present, the code was unable to initialize many default common variables for players, which resulted in an error while trying to pull data from theRosterclass.Fixes #456
Signed-Off-By: Robert Clark [email protected]