Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lively Properties JSON Schema #1542

Conversation

dejohansson
Copy link
Contributor

  • Not sure where the schema should be placed so I put it in the root folder for now.
  • I haven't been able to figure out what the "tick" property on the slider setting does so I left its description empty for now.

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2023

CLA assistant check
All committers have signed the CLA.

@dejohansson
Copy link
Contributor Author

dejohansson commented Jan 27, 2023

This adds the JSON schema discussed in #1468

@rocksdanister
Copy link
Owner

rocksdanister commented Jan 27, 2023

maybe its better to create a schemas folder in root and move it ther?
"tick" was used to show intervals in slider UI, no longer being used now.

@dejohansson
Copy link
Contributor Author

maybe its better to create a schemas folder in root and move it ther?

Sounds good 👍 It's moved now.

"tick" was used to show lines in the UI for step, no longer being used now.

Alright, I removed the property from the schema. I assume it should also be removed from the wiki (here and here) to mitigate confusion in the future?

@rocksdanister
Copy link
Owner

Looks good 🥳

@rocksdanister rocksdanister merged commit 0022fef into rocksdanister:core-separation Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants