Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove nav border after firefox 122.0 upgrade #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eggnog-plus
Copy link

OS: Ubuntu 22.04.3 LTS
Version 122.0 64-bit (Standard)

The most recent Firefox upgrade added this thin border to the top of the window:

before

This change removes it:

after


Great project! Thanks for hosting it.

@rockofox
Copy link
Owner

Bildschirmfoto 2024-01-28 um 17 13 19 Bildschirmfoto 2024-01-28 um 17 15 26

Hmm, I tried reproducing this both on NixOS + Firefox 122 and macOS + Firefox 123/Dev, but I didn't run into the issue.

What theme are you using in Firefox? Maybe it's somehow related to that

@eggnog-plus
Copy link
Author

Ah, it might be the desktop environment. Just like you, I don't see anything using Gnome. I typically use i3 without a desktop environment, which is when I see the border.

@rockofox
Copy link
Owner

Bildschirmfoto 2024-02-15 um 20 19 47

Hmm, weird, I tried it out on i3 default configuration with no desktop environment and still can't see any border

@eggnog-plus
Copy link
Author

I think this pixel row in your screenshot could be the border I'm seeing. See if it's still there when only one Firefox tab is open (making the tab row disappear).

Screenshot from 2024-02-16 17-11-46

I was able to reproduce with a fresh Ubuntu Server 22.04.3 install and apt install i3 xinit firefox. Then I installed lightdm too and noticed that the border changes color when I updated the desktop appearance back and forth between Light and Dark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants