const support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Additional function : --version
- add --version arguments in command line
- I think that modified version will be 0.3
# Bug : What is the problem
- we have the error when we use enum without name.
```
enum {
AAAAAAA,
BBBBBBB,
};
```
- Error Message
```
[1133] WARN-enum: nameless enum ['enum', '{', 'AAAAAAA', ',', 'BBBBBBB', ',', '}']
Traceback (most recent call last):
File "/Users/cheoljoo/.local/bin/hpp2plantuml", line 11, in <module>
load_entry_point('hpp2plantuml==0.2', 'console_scripts', 'hpp2plantuml')()
File "/Users/cheoljoo/.local/lib/python3.6/site-packages/hpp2plantuml-0.2-py3.6.egg/hpp2plantuml/hpp2plantuml.py", line 1110, in main
CreatePlantUMLFile(args.input_files, args.output_file)
File "/Users/cheoljoo/.local/lib/python3.6/site-packages/hpp2plantuml-0.2-py3.6.egg/hpp2plantuml/hpp2plantuml.py", line 1080, in CreatePlantUMLFile
diag.create_from_file_list(list(set(expand_file_list(file_list_c))))
File "/Users/cheoljoo/.local/lib/python3.6/site-packages/hpp2plantuml-0.2-py3.6.egg/hpp2plantuml/hpp2plantuml.py", line 768, in create_from_file_list
flag_build_lists=True, flag_reset=True)
File "/Users/cheoljoo/.local/lib/python3.6/site-packages/hpp2plantuml-0.2-py3.6.egg/hpp2plantuml/hpp2plantuml.py", line 747, in _build_helper
self.parse_objects(single_input, build_from_single)
File "/Users/cheoljoo/.local/lib/python3.6/site-packages/hpp2plantuml-0.2-py3.6.egg/hpp2plantuml/hpp2plantuml.py", line 860, in parse_objects
self._objects.append(container_handler(obj))
File "/Users/cheoljoo/.local/lib/python3.6/site-packages/hpp2plantuml-0.2-py3.6.egg/hpp2plantuml/hpp2plantuml.py", line 32, in <lambda>
['enums', lambda objs: objs, lambda obj: Enum(obj)]
File "/Users/cheoljoo/.local/lib/python3.6/site-packages/hpp2plantuml-0.2-py3.6.egg/hpp2plantuml/hpp2plantuml.py", line 486, in __init__
super().__init__('enum', header_enum['name'])
KeyError: 'name'
```
- Changed Code
- This error generates when it is not defined the key of dictionary.
- So define "empty" name as a default value when enum does not have the name.
- super().__init__('enum', header_enum['name']) -> super().__init__('enum', header_enum.get('name',empty))
- output
```
@startuml
enum empty {
AAAAAAA
BBBBBBB
}
@enduml
```
Add test for anonymous enum
Fix bug with multiline template parameters Fix bug with class enum objects (not supported but should not crash)
- Merge dependency relationship - Support complex parameter types (containers) - Fix naming convention for aggregation (parent/child) - Determine aggregation/composition (raw pointer->aggregation) - Fix typos - Fix sphinx build issues
Co-authored-by: themmj <[email protected]>
thibaultmarin
force-pushed
the
master
branch
from
8111cd8 to
27eb751
Compare
thibaultmarin
force-pushed
the
master
branch
6 times, most recently
from
b30bad2 to
0f72d6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.