SimpleController: fix sending commands without having any input samples #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 30, 2015 19:31
If a data connection to the input port exists the controller sends old data as new commands even if no new input samples are available. This results in a dangerous behaviour commanding the robot to move without any timeout. The new implementation repeats the command until a timeout interval passed. After this stop commands are sent until a new input sample arrived. This ensures that if the commanding component freezes or forgets to send a stop command the robot stops after n seconds.
base/MotionCommand2D is the old name and currently a typedef for base/commands/Motion2d. MotionCommand2D is going to be removed from base/types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a data connection to the input port exists the controller sends old
data as new commands even if no new input samples are available. This
results in a dangerous behaviour commanding the robot to move without
any timeout.
The new implementation repeats the command until a timeout
interval passed. After this, stop commands are sent until a new
input sample arrived. This ensures that if the commanding component
freezes or forgets to send a stop command the robot stops after n
seconds.