Async measure: remove getLayoutSize from video-manager-impl (ampproje…

…ct#33770)
rochapablo · Aug 30, 2021 · 37b1c6e · 37b1c6e
1 parent f7cac69
commit 37b1c6e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/build-system/test-configs/forbidden-terms.js b/build-system/test-configs/forbidden-terms.js
@@ -1117,7 +1117,6 @@ const forbiddenTermsSrcInclusive = {
       'src/iframe-helper.js',
       'src/service/mutator-impl.js',
       'src/service/resources-impl.js',
-      'src/service/video-manager-impl.js',
       'extensions/amp-a4a/0.1/amp-a4a.js',
       'extensions/amp-fx-flying-carpet/0.1/amp-fx-flying-carpet.js',
       'extensions/amp-script/0.1/amp-script.js',

diff --git a/src/service/video-manager-impl.js b/src/service/video-manager-impl.js
@@ -997,8 +997,12 @@ class VideoEntry {
    */
   getAnalyticsDetails() {
     const {video} = this;
-    return this.supportsAutoplay_().then((supportsAutoplay) => {
-      const {width, height} = video.element.getLayoutSize();
+    const supportsAutoplay = this.supportsAutoplay_();
+    const intersection = measureIntersection(video.element);
+    return Promise.all([supportsAutoplay, intersection]).then((responses) => {
+      const supportsAutoplay = /** @type {boolean} */ (responses[0]);
+      const intersection = /** @type {!IntersectionObserverEntry} */ (responses[1]);
+      const {width, height} = intersection.boundingClientRect;
       const autoplay = this.hasAutoplay && supportsAutoplay;
       const playedRanges = video.getPlayedRanges();
       const playedTotal = playedRanges.reduce(