Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding cmake configuration to download roc-toolkit with branch provided via cmake variable #10
Adding cmake configuration to download roc-toolkit with branch provided via cmake variable #10
Changes from 2 commits
8daee43
c475744
e452f8e
7f109ab
d674cfa
168b062
37300cc
f353504
e19223c
1deb0e4
f44bd13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should uncomment it to allow cross-compiling.
Here is the code that detects CMAKE_CXX_COMPILER_TARGET if it's empty: https://github.com/roc-streaming/roc-pulse/blob/main/cmake/setup_toolchain.cmake (starting from
else(TOOLCHAIN_PREFIX)
).That code also allows using
TOOLCHAIN_PREFIX
option, which I think can be useful for rt-tests too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uncommented these lines, but I am not sure what needs to be done for cross compilation. Can this be done in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing.
I've created a separate issue for cross-compilation: #11
Feel free to pick it up or ignore it.