Minor fixes #108
Merged
Minor fixes #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gavv
commented
May 13, 2023
gavv
commented
- Remove versionCode and versionName from AAR (https://stackoverflow.com/questions/74519040/)
- Set default API level in android_docker.sh to 26 (same as minSdkVersion in gradle)
- set default API level to 26 (same as minSdkVersion in gradle) - use curly braces
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
=========================================
Coverage 74.70% 74.70%
Complexity 79 79
=========================================
Files 24 24
Lines 419 419
Branches 2 2
=========================================
Hits 313 313
Misses 102 102
Partials 4 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.