Skip to content

Commit

Permalink
Cleanup in scripts
Browse files Browse the repository at this point in the history
- set default API level to 26 (same as minSdkVersion in gradle)
- use curly braces
  • Loading branch information
gavv authored and ortex committed May 13, 2023
1 parent b7f6445 commit 4be8ba3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions scripts/android/start_emulator.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

set -euxo pipefail

export PATH="$ANDROID_SDK_ROOT/tools/bin:${PATH}"
export PATH="$ANDROID_SDK_ROOT/cmdline-tools/latest/bin:${PATH}"
export PATH="${ANDROID_SDK_ROOT}/tools/bin:${PATH}"
export PATH="${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin:${PATH}"

# create avd if it doesn't exist
if ! avdmanager list avd -c | grep -qF roc_device
Expand Down
2 changes: 1 addition & 1 deletion scripts/android_docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function run_cmd() {

# setup default values
: "${JAVA_VERSION:=8}"
: "${API:=28}"
: "${API:=26}"
: "${NDK_VERSION:=21.1.6352462}"
: "${BUILD_TOOLS_VERSION:=28.0.3}"
: "${CMAKE_VERSION:=3.10.2.4988404}"
Expand Down

0 comments on commit 4be8ba3

Please sign in to comment.