Skip to content

feat: add support for StrimziPodSet #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sappusaketh
Copy link
Contributor

@sappusaketh sappusaketh commented Jan 1, 2025

fixes #372

@CLAassistant
Copy link

CLAassistant commented Jan 1, 2025

CLA assistant check
All committers have signed the CLA.

@aantn
Copy link
Contributor

aantn commented Jan 6, 2025

Hi @sappusaketh, thank you for the PR! Can you explain the changes to the build system and python version? I assume you're fixing something broken there?

@sappusaketh
Copy link
Contributor Author

Hi @sappusaketh, thank you for the PR! Can you explain the changes to the build system and python version? I assume you're fixing something broken there?

Hi @aantn, those ci changes are mainly to improve maintainability, and version bumps are to update outdated Github Actions versions

@arikalon1 arikalon1 requested a review from Avi-Robusta January 7, 2025 09:19
@sappusaketh
Copy link
Contributor Author

sappusaketh commented Jan 7, 2025

reason for python version bump in poetry's pyproject.toml is to support all 3.12.x

@aantn
Copy link
Contributor

aantn commented Jan 8, 2025

@sappusaketh would it be possible to move changes to CI/CD to a separate PR please? That will help us merge this faster, as our security policy requires multiple reviewers on our side for anything CI/CD due to potential for accidentally impacting supply chain security.

@sappusaketh
Copy link
Contributor Author

@aantn do you want me to undo poetry changes as well?

Signed-off-by: Saketh kappala <[email protected]>
@sappusaketh
Copy link
Contributor Author

updated PR to show only StrimziPodSet changes

@aantn
Copy link
Contributor

aantn commented Jan 8, 2025

Yes, thank you! @Avi-Robusta please get this merged if there are no more comments!

@Avi-Robusta Avi-Robusta merged commit 89d1b9f into robusta-dev:main Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for StrimziPodSets
4 participants