-
Notifications
You must be signed in to change notification settings - Fork 200
feat: add support for StrimziPodSet #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for StrimziPodSet #388
Conversation
Signed-off-by: Saketh kappala <[email protected]>
Signed-off-by: Saketh kappala <[email protected]>
Signed-off-by: Saketh kappala <[email protected]>
Hi @sappusaketh, thank you for the PR! Can you explain the changes to the build system and python version? I assume you're fixing something broken there? |
Hi @aantn, those ci changes are mainly to improve maintainability, and version bumps are to update outdated Github Actions versions |
…t in Docker workflow Signed-off-by: Saketh kappala <[email protected]>
reason for python version bump in poetry's pyproject.toml is to support all 3.12.x |
Signed-off-by: Saketh kappala <[email protected]>
Signed-off-by: Saketh kappala <[email protected]>
@sappusaketh would it be possible to move changes to CI/CD to a separate PR please? That will help us merge this faster, as our security policy requires multiple reviewers on our side for anything CI/CD due to potential for accidentally impacting supply chain security. |
@aantn do you want me to undo poetry changes as well? |
Signed-off-by: Saketh kappala <[email protected]>
Signed-off-by: Saketh kappala <[email protected]>
updated PR to show only StrimziPodSet changes |
Yes, thank you! @Avi-Robusta please get this merged if there are no more comments! |
fixes #372