feat: suport entra id #210
Draft
+276
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikalon1
reviewed
Nov 21, 2024
| @@ -41,6 +41,18 @@ def completion(self, messages: List[Dict[str, Any]], tools: Optional[List[Tool]] | |||
| pass | |||
|
|
|||
|
|
|||
| def get_lite_llm_config(api_key:Optional[str], base_url:Optional[str]) -> Dict[str, Any]: | |||
|
|
|||
| if os.environ.get("AZURE_API_BASE"): | |||
There was a problem hiding this comment.
will this work with the way we guide users to use azure openai?
https://docs.robusta.dev/master/configuration/ai-analysis.html#choosing-and-configuring-an-ai-provider
There was a problem hiding this comment.
it should, This just avoids setting the api_key and base_url explicitly but litellm can read these though env vars, which is how we tell users to configure holmes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.