Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom LLM implementation #174

Merged
merged 11 commits into from
Nov 5, 2024

Conversation

nherment
Copy link
Contributor

@nherment nherment commented Nov 1, 2024

This adds the ability to inject your own LLM into holmesgps when you invoke it as a library.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@nherment nherment changed the title feat: WIP, Suport custom LLM implementation Support custom LLM implementation Nov 1, 2024
@nherment nherment marked this pull request as ready for review November 1, 2024 10:26
@nherment nherment requested review from aantn and arikalon1 November 1, 2024 10:26
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

I think we missed something.
This method, still returns ToolCallingLLM

I think it causes an issue here because it doesn't contain the required methods anymore

WDYT?

messages=messages,
tools=tools,
tool_choice=tool_choice,
base_url=self.base_url,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we remove the base_url, temperature and drop_params?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed temp & drop_params. base_url is implementated in the DefaultLLM

@nherment
Copy link
Contributor Author

nherment commented Nov 4, 2024

I think we missed something.
This method, still returns ToolCallingLLM

I think it causes an issue here because it doesn't contain the required methods anymore

The code has been updated to reach into the llm object of the toolCalling instance:
image

Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@arikalon1 arikalon1 merged commit d14ccbf into master Nov 5, 2024
9 checks passed
@arikalon1 arikalon1 deleted the main-2433_allow_custom_llm_functions branch November 5, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants