Add missing dependency metrics-lwt#114
Merged
hannesm merged 1 commit intoJan 13, 2026
Merged
Conversation
reynir
requested changes
Dec 20, 2025
Contributor
reynir
left a comment
reynir
left a comment
There was a problem hiding this comment.
Thanks! I'm not sure why we observe this in CI - maybe another dependency pulls it in. But we use it directly so it's good to specify it as a dependency.
previous error: mirage-dnsvizor-unix-dev> File "unikernel.ml", line 1788, characters 4-29: mirage-dnsvizor-unix-dev> 1788 | Metrics_lwt.init_periodic (fun () -> Mirage_sleep.ns (Duration.of_sec 10)); mirage-dnsvizor-unix-dev> ^^^^^^^^^^^^^^^^^^^^^^^^^ mirage-dnsvizor-unix-dev> Error: Unbound module Metrics_lwt
jian-lin
force-pushed
the
pr/add-missing-depepdency-metrics-lwt
branch
from
468b0e7 to
27f2e7a
Compare
13 tasks
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous error:
mirage-dnsvizor-unix-dev> File "unikernel.ml", line 1788, characters 4-29:
mirage-dnsvizor-unix-dev> 1788 | Metrics_lwt.init_periodic (fun () -> Mirage_sleep.ns (Duration.of_sec 10));
mirage-dnsvizor-unix-dev> ^^^^^^^^^^^^^^^^^^^^^^^^^
mirage-dnsvizor-unix-dev> Error: Unbound module Metrics_lwt