Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move assertions from Map to MapLikeAssertions (remove Map..) #734

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

robstoll
Copy link
Owner

moreover:


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

moreover:
- introduce Map.size based on CollectionLike
- deprecated DescriptionMapAssertion and duplicate in
  DescriptionMapLikeAssertion
@robstoll robstoll linked an issue Dec 22, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #734 (ac00c4e) into master (d1fa72c) will decrease coverage by 0.09%.
The diff coverage is 84.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #734      +/-   ##
============================================
- Coverage     87.98%   87.88%   -0.10%     
  Complexity       16       16              
============================================
  Files           936      936              
  Lines          8378     8381       +3     
  Branches        388      389       +1     
============================================
- Hits           7371     7366       -5     
- Misses          932      940       +8     
  Partials         75       75              
Flag Coverage Δ Complexity Δ
bbc 78.70% <70.00%> (-0.09%) 0.00 <0.00> (ø)
bc 57.09% <0.00%> (-0.03%) 0.00 <0.00> (ø)
current 59.69% <84.00%> (-0.11%) 0.00 <0.00> (ø)
current_windows 58.11% <84.00%> (-0.11%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...um/api/fluent/en_GB/mapCollectionLikeAssertions.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ium/api/infix/en_GB/mapCollectionLikeAssertions.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rc/generated/kotlin/ch/tutteli/atrium/logic/any.kt 90.00% <ø> (-10.00%) 0.00 <0.00> (ø)
...hbehaviours/impl/InOrderOnlySearchBehaviourImpl.kt 50.00% <0.00%> (ø) 0.00 <0.00> (ø)
...earchbehaviours/impl/InOrderSearchBehaviourImpl.kt 50.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../tutteli/atrium/logic/logicIterableLIkeContains.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...h/tutteli/atrium/api/fluent/en_GB/mapAssertions.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ch/tutteli/atrium/api/infix/en_GB/mapAssertions.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...enerated/kotlin/ch/tutteli/atrium/logic/mapLike.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ontains/creators/impl/InOrderOnlyEntriesMatcher.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1fa72c...5309870. Read the comment docs.

@robstoll robstoll merged commit de932d3 into master Dec 23, 2020
@robstoll robstoll deleted the MapLike branch December 23, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Map.size Turn MapAssertions into MapLikeAssertions
1 participant