make generateLogic more readable with named matches #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstoll
requested changes
Oct 8, 2020
There was a problem hiding this comment.
@jgrgt thanks for your work but I am afraid that I don't have use for the vararg part. We never use vararg on the logic level, that's also the reason why we don't support it. Have a look at #590 the task list is only for api-fluent nothing to do in the logic level.
Anyhow.. I still think that the named groups are an improvement. Thus, can you please revert the vararg part and only keep the named groups.
|
@robstoll I removed the vararg parts but left the named groups. |
robstoll
approved these changes
Oct 8, 2020
| def patterns = (6..0).collect { int amountOfParameters -> | ||
| def params = [] | ||
| if (amountOfParameters > 0) { | ||
| params = (1..amountOfParameters).toList() |
There was a problem hiding this comment.
tiny detail (just as info) toList is not required
Suggested change
| params = (1..amountOfParameters).toList() | |
| params = (1..amountOfParameters) |
|
@jgrgt thanks for your first contribution to Atrium 🙂 👍 |
robstoll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started looking at #590 and noticed one of the problems with fixing that is the use of vararg: generateLogic failed to work because it could not match that 'vararg'.
So I fixed that. Because I could not figure out the index-based regex, I moved everything to named groups first and then added the vararg. I don't like the way I had to abuse string interpolation to specify the named group referenced, but that's the best I could come up with.
Note that the vararg does not get 'expanded', so the underlying code needs to accept an
Arrayinstead of the vararg.I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.