Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jvm testNG sample #1584

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

Zuretto
Copy link
Contributor

@Zuretto Zuretto commented Oct 25, 2023

Outline

Added TestNG sample to the project.
Included removing TestNG runner Stack frames in the source code.

Issue

#1562


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@Zuretto Zuretto requested a review from robstoll as a code owner October 25, 2023 09:56
@Zuretto
Copy link
Contributor Author

Zuretto commented Oct 25, 2023

Hi @robstoll, I was not sure if removing TestNG runner stack frames should be added to the project. I thought it would be good to add it in this PR when I was searching the repository for kotest usages.

Please let me know if it should be part of the PR or if I should exlude it completely or create new PR for that one change.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d860e1) 91.84% compared to head (4f35973) 91.84%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1584   +/-   ##
=========================================
  Coverage     91.84%   91.84%           
  Complexity      114      114           
=========================================
  Files           425      425           
  Lines          4608     4608           
  Branches        228      228           
=========================================
  Hits           4232     4232           
  Misses          330      330           
  Partials         46       46           
Flag Coverage Δ
current 91.40% <ø> (ø)
current_windows 90.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zuretto Zuretto force-pushed the feature/testNG-sample branch from 4f35973 to 0b88b83 Compare October 26, 2023 22:31
@robstoll robstoll merged commit 0128891 into robstoll:main Oct 27, 2023
9 checks passed
@robstoll
Copy link
Owner

@Zuretto thanks for your first contribution to Atrium 👍

How about another one?

@Zuretto Zuretto deleted the feature/testNG-sample branch October 27, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create sample project to demonstrate how Atrium can be used in combination with TestNG
2 participants