Migrate files from DescribeSpec to FunSpec #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js target doesn't support Describe Spec of Kotest hence we have to migrate the spek to Fun spec before enabling js target again. I am migrating the already migrated DescribeSpec files to FunSpec.
|
@Dark-Knight11 looks good IMO, do you want to do something in addition (as you named it WIP which stands for work in progress)? Otherwise we can merge it 👍 |
|
yeah I'm working on migration of other files as well. |
Migrated the AdjustStackSpec.kt file form Spek to Kotest using FunSpec. Changed all the imports of spek framework to kotest framework.
Dark-Knight11
changed the title
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js target doesn't support Describe Spec of Kotest hence we have to migrate the spek to Fun spec before enabling js target again.
I am migrating the already migrated DescribeSpec files to FunSpec.
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.