-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add samples for pathExpectations of api-infix #999
Comments
I'll work on this |
Hi @robstoll, As this is my first PR in this project, I have one question to clarify. Even though you mentioned there are only 7 infix functions for pathExpectations where as for fluent there are 18 functions. Please let me know if my understanding is correct. |
@rhushikesh good point, I forgot to mention, that some functions are still in pathAssertions.kt for binary backward compatibility reasons. You should have the same sample functions in the end as in PathExpectationSamples for api-fluent. |
Platform (all, jvm, js, android): all
Extension (none, kotlin 1.3): none
Code related feature
We also want to provide samples for the infix api
Following the things you need to do:
...api.fluent...
to...api.infix...
and adjust the samples accordingly (always use the infix syntax, never the fluent).Your first contribution?
I'll work on this
if you would like to take this issue over.This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
(Invite yourself in case you do not have an account yet).
The text was updated successfully, but these errors were encountered: