Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples for Iterable feature extractors #1569

Closed
5 tasks
robstoll opened this issue Oct 15, 2023 · 1 comment · Fixed by #1708
Closed
5 tasks

samples for Iterable feature extractors #1569

robstoll opened this issue Oct 15, 2023 · 1 comment · Fixed by #1708
Assignees
Labels
Milestone

Comments

@robstoll
Copy link
Owner

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

api-fluent
api-fluent

  • add a minFeature method in IterableFeatureExtractorSamples for expect(iterable).min()
  • add a min method IterableFeatureExtractorSamples for expect(iterable).min { } (i.e. the overload with the assertionCreator-lambda)
  • add a maxFeature method in IterableFeatureExtractorSamples for expect(iterable).max()
  • add a max method IterableFeatureExtractorSamples for expect(iterable).max { } (i.e. the overload with the assertionCreator-lambda)
  • link in the KDoc of the corresponding function in iterableLikeToContain...Creators.kt to the samples via @sample (see charSequenceToContainCreators.kt)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@constantine-zubrylin
Copy link
Contributor

Can I take it?

constantine-zubrylin added a commit to constantine-zubrylin/atrium that referenced this issue Feb 18, 2024
@robstoll robstoll linked a pull request Feb 20, 2024 that will close this issue
@robstoll robstoll added this to the 1.2.0 milestone Feb 20, 2024
constantine-zubrylin added a commit to constantine-zubrylin/atrium that referenced this issue Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants