Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notToBeAnInstanceOf #1400

Closed
10 tasks
vlsi opened this issue Apr 20, 2023 · 5 comments · Fixed by #1453 or #1540
Closed
10 tasks

Add notToBeAnInstanceOf #1400

vlsi opened this issue Apr 20, 2023 · 5 comments · Fixed by #1453 or #1540
Assignees
Labels
Milestone

Comments

@vlsi
Copy link
Collaborator

vlsi commented Apr 20, 2023

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

expect("test").notToBeAnInstanceOf<Throwable>()

Following the things you need to do:

logic

  • extend AnyAssertions with a function notToBeAnInstanceOf (see AnyAssertions.toBe as a guideline)
  • implement notToBeAnInstanceOf in DefaultAnyAssertions.kt (see DefaultAnyAssertions toBe)

api-fluent

  • provide the fun notToBeAnInstanceOf anyExpectations.kt (see anyExpectations.kt toEqual and toBeAnInstanceOf as a guideline)
    • add NOT_TO_BE_THE_INSTANCE_OF to DescriptionAnyExpectation en_GB
    • add NOT_TO_BE_THE_INSTANCE_OF to DescriptionAnyExpectation de_CH, use "ist nicht eine Instanz vom Typ"
  • add @since 1.1.0 (adapt to current milestone) to KDOC
  • extend AnyExpectationsSpec in specs -> commonMain and modify it in atrium-api-fluent-en_GB -> commonTest accordingly

api-infix

  • provide the fun notToBeAnInstanceOf which returns Expect<T> in anyExpectations.kt (see anyExpectations.kt toEqual and toBeAnInstanceOf as a guideline)
  • add @since 1.1.0 (adapt to current milestone) to KDOC
  • modify atrium-api-infix-en_GB -> commonTest accordingly

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@tanbirali
Copy link

Hello please assign this to me

@tanbirali
Copy link

Thank you @vlsi will start working on it soon

@Jujusp
Copy link
Contributor

Jujusp commented May 16, 2023

Hey! Would like to work on this @vlsi @robstoll . @tanbirali are you working on it?

@robstoll
Copy link
Owner

@Jujusp you can work on it as well IMO.

@Jujusp Jujusp removed their assignment May 21, 2023
@AncutaIoan
Copy link
Contributor

Hi there, I'll work on this

@robstoll robstoll assigned AncutaIoan and unassigned tanbirali May 30, 2023
@robstoll robstoll linked a pull request Sep 10, 2023 that will close this issue
robstoll added a commit to AncutaIoan/atrium that referenced this issue Sep 10, 2023
@robstoll robstoll added this to the 1.1.0 milestone Sep 10, 2023
@robstoll robstoll linked a pull request Sep 13, 2023 that will close this issue
robstoll added a commit that referenced this issue Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants