Skip to content

docs(hot-path): flip remaining R7c gating language to deferred-with-evidence (#848) - #860

Merged
github-actions[bot] merged 1 commit into
mainfrom
docs/issue-848-r7c-inline-comments
May 18, 2026
Merged

docs(hot-path): flip remaining R7c gating language to deferred-with-evidence (#848)#860
github-actions[bot] merged 1 commit into
mainfrom
docs/issue-848-r7c-inline-comments

Conversation

@robotrocketscience

@robotrocketscience robotrocketscience commented May 18, 2026

Copy link
Copy Markdown
Owner

Summary

Reconciles three sister inline references that were missed when PR #821
/ PR #852 flipped the R7c gating language to deferred-with-evidence
in docs/feature-hot-path.md and src/aelfrice/hot_path.py.

src/aelfrice/hot_path.py:22-28 already reads as of #852:

R7c (2026-05-15) found production posterior-touch correlation above
the 0.60 crossover R7b pre-committed (rho_mixed = +0.87 on the
aelfrice corpus, +0.72 on an independent corpus); the
originally-modelled posterior-rerank touch-temperature multiplier is
deferred-with-evidence and is not scheduled. … See #848 for the tracker.

These three sister sites still read as "gated on R7c (pending fidelity
test)" on github/main:

  • src/aelfrice/hook.py:961-963 — touch-record block, comment above
    _record_touches call site
  • src/aelfrice/hook.py:1195_record_touches function docstring
  • src/aelfrice/store.py:490-492belief_touches CREATE-table
    comment

This patch flips all three to match the shipped outcome with #848 as
the tracker.

Scope

Pure comment / docstring change. No behavior change.

#848 lists three explicit acceptance items (docs/feature-hot-path.md
amend, hot_path.py docstring amend, scripts/probe_posterior_touch_correlation.py
add). All three shipped under PR #852 and PR #853. This PR addresses
adjacent in-tree stale references that the explicit acceptance
items did not enumerate, but which are now factually wrong against the
shipped outcome. Operator confirmed scope expansion before this branch
opened.

Verification

  • grep -rnE 'gated on .*R7c|gated on the H3' src/ docs/ → no hits
    after the patch
  • tests/test_hot_path_touch_state.py → 22/22 pass (one scipy cold-
    import flake on first run; passed clean on retry)
  • Discretion grep on diff against github/main → clean
  • Commit signed (G)

Out of scope

Summary by Sourcery

Documentation:

  • Clarify that the posterior-rerank touch-temperature multiplier consumer is deferred-with-evidence post-R7c and not scheduled, updating hook and store comments/docstrings accordingly.

Summary by CodeRabbit

  • Documentation
    • Updated internal documentation to reflect current system state and defer certain behaviors post-release.

Review Change Stack

…vidence (#848)

The R7c outcome (ρ_mixed=+0.87 aelfrice / +0.72 independent) flipped the
posterior-rerank touch-temperature consumer from "gated on R7c" to
"deferred-with-evidence — not scheduled". PR #852 / #821 review updated
docs/feature-hot-path.md and src/aelfrice/hot_path.py docstring; three
sister inline references in hook.py (touch-record block + _record_touches
docstring) and store.py (belief_touches CREATE block) were missed and
still read as if the campaign was pending. This patch flips those three
locations to match the shipped outcome, with #848 as the tracker.
@sourcery-ai

sourcery-ai Bot commented May 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates stale R7c gating comments/docstrings in the hot-path touch recording and belief_touches storage code to reflect that the originally-modeled rerank consumer is now deferred-with-evidence post-R7c, with #848 as the tracker, without changing runtime behavior.

File-Level Changes

Change Details Files
Align hot-path hook comments with deferred-with-evidence R7c outcome for the rerank consumer. src/aelfrice/hook.py
Align belief_touches CREATE-table comment with deferred-with-evidence status and future H3 mechanism intent.
  • Adjust belief_touches table-level comment to say the originally-modeled posterior-rerank touch-temperature multiplier is deferred-with-evidence post-R7c and not scheduled, referencing hot-path: H3 consumer flip deferred-with-evidence (R7c outcome) #848, and note that accumulated writes are kept as substrate for any future H3 mechanism with new falsification criteria.
src/aelfrice/store.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 818e774f-216b-4e97-b9fe-08e4003fcd07

📥 Commits

Reviewing files that changed from the base of the PR and between 58f1cd9 and 89b65d5.

📒 Files selected for processing (2)
  • src/aelfrice/hook.py
  • src/aelfrice/store.py

📝 Walkthrough

Walkthrough

This PR updates inline comments across two modules to document that the rerank consumer and touch-temperature multiplier behavior is deferred-with-evidence post-R7c and not currently scheduled, while retaining the underlying touch-write substrate for potential future mechanisms.

Changes

R7c Deferral Documentation

Layer / File(s) Summary
Updated consumer and schema comments
src/aelfrice/hook.py, src/aelfrice/store.py
Comments updated to clarify that the rerank consumer (lines 961–963) and touch-temperature multiplier consumer (lines 1195–1198) are deferred-with-evidence post-R7c and not scheduled. The belief_touches schema comment (lines 491–495) extended to explain that touch writes are retained as substrate for potential future H3 mechanisms despite the consumer deferral.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: updating R7c gating language to deferred-with-evidence in documentation/comments.
Description check ✅ Passed The description follows the template structure with Summary, linked issues (#848), type of change (docs), verification steps, and test results documented.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/issue-848-r7c-inline-comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@robotrocketscience robotrocketscience added the author-idnn PR authored by session idnn label May 18, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@robotrocketscience robotrocketscience added attn:review Needs review (PR open, awaiting reviewer) ready-to-merge Trigger merge-train: FF main to this PR's head labels May 18, 2026
@github-actions github-actions Bot removed the ready-to-merge Trigger merge-train: FF main to this PR's head label May 18, 2026
@github-actions

Copy link
Copy Markdown

merge-train: merged 89b65d5main via FF push.

@github-actions
github-actions Bot merged commit 89b65d5 into main May 18, 2026
40 of 48 checks passed
@robotrocketscience
robotrocketscience deleted the docs/issue-848-r7c-inline-comments branch May 20, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attn:review Needs review (PR open, awaiting reviewer) author-idnn PR authored by session idnn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant