docs(wonder): refresh slash dedup-behaviour paragraph for shipped #644 v2 key - #715
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the wonder slash command documentation to accurately describe the new v2 deduplication/idempotency contract shipped in #644, reflecting that the idempotency key now includes both belief IDs and generator string. Flow diagram for updated wonder_ingest v2 dedup behaviourflowchart TD
A[Wonder dispatch with speculative_anchor_ids and axes] --> B[Compute generator per axis]
B --> C[Call wonder_ingest]
C --> D["lifecycle._wonder_ingest_idempotency_key(belief_ids, generator)"]
D --> E{Idempotency key exists?}
E -- No --> F[Persist phantom doc for this generator]
E -- Yes --> G[Skip insert for this generator]
F --> H[One phantom per axis on first dispatch]
G --> I[Re-running same dispatch is a no-op]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated documentation for the Changeswonder_ingest idempotency documentation
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5ea85b6 to
ed26707
Compare
|
merge-train: blocked branch is not fast-forward on The |
…v2 key The 'Known dedup behaviour' note in src/aelfrice/slash_commands/wonder.md described the pre-#644 contract (constituent-IDs-only key, N-1 axis rows collapsed to skipped) and pointed at #644 as a future follow-up. #644 has shipped on github/main: lifecycle._wonder_ingest_idempotency_key now hashes sorted constituent IDs PLUS the generator string with prefix 'wonder_ingest:v2:', and an N-axis dispatch persists as N distinct phantoms. Update the slash doc to reflect the shipped contract.
ed26707 to
e8ba796
Compare
|
merge-train: merged e8ba796 → |
Summary
Tiny doc-only fix surfaced while closing out umbrella #645 (wonder/reason agentmemory parity).
src/aelfrice/slash_commands/wonder.mdended its dispatch-flow process block with a "Known dedup behaviour" paragraph describing the pre-#644 contract:#644 shipped on
github/main(sub-task of #552 / umbrella #645):lifecycle._wonder_ingest_idempotency_keynow hashes sorted constituent IDs and the generator string with prefixwonder_ingest:v2:. CHANGELOG## [Unreleased]entry "Dedup contract — option 2 (#644)" documents the new shape; the slash doc was the only place still describing the old contract.Replaced the paragraph with an accurate "Dedup behaviour" note that matches the shipped key. Operators reading
/aelf:wonderafter the--axesdispatch will no longer expect N-1 rows to silentlyskippedaway.Test plan
pytest tests/test_wonder_skill_integration_e2e.py tests/test_lifecycle.py -q→ 47 passed, 2 skipped (no behavior change; doc only)github/main→ cleanaelf-pr-open.shrebase + pytest + discretion gateCloses part of #645 acceptance ("
slash_commands/wonder.mdmirrors the agentmemory 7-step process adapted for the merged CLI"); umbrella close-out tracked separately.Summary by Sourcery
Documentation:
Summary by CodeRabbit