docs(vocab_bridge): cite default dim=512 alongside dim=2048 escape-hatch (#541) - #543
Conversation
…tch (#541) vocab_bridge.py:113 docstring still cited dim=2048 as the implied default for the (N_surfaces, dim) storage estimate. After PR #539 flipped DEFAULT_DIM 2048 -> 512, the same N=10k configuration is ~40 MB, not ~160 MB. Rewrite the line to mirror the hrr_index.py:107-110 pattern: default first, escape-hatch in parentheses.
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the VocabBridge storage-cost docstring to present dim=512 as the default dimension with dim=2048 as an escape-hatch value, aligning its wording with hrr_index.py’s documentation and leaving behavior unchanged. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[claim:review:Faraday:2026-05-10T04:35:29Z] |
|
[release:review:Faraday:2026-05-10T04:36:37Z] |
Closes #541.
Updates the
VocabBridgestorage-cost docstring (src/aelfrice/vocab_bridge.py:113) to citedim=512(the post-#539 default viafrom aelfrice.hrr import DEFAULT_DIM) as the primary number, withdim=2048shown as the escape-hatch path. Mirrors the format already used inhrr_index.py:107-110from PR #539.8 * 10000 * 512 ≈ 40 MB;8 * 10000 * 2048 ≈ 160 MB(unchanged).Acceptance
hrr_index.py:107-110style.dim=2048references that read as default-cited: only one (the cited line); otherdimreferences either don't carry a numeric value or pull fromDEFAULT_DIMdirectly.Out of scope
References
Summary by Sourcery
Documentation: