Skip to content

docs(v2-reentry-queue): point H1 row at split issue #374 - #375

Merged
robotrocketscience merged 1 commit into
mainfrom
docs/issue-199-split-queue-link
May 3, 2026
Merged

docs(v2-reentry-queue): point H1 row at split issue #374#375
robotrocketscience merged 1 commit into
mainfrom
docs/issue-199-split-queue-link

Conversation

@yoshi280

@yoshi280 yoshi280 commented May 3, 2026

Copy link
Copy Markdown
Collaborator

What

One-line update to docs/V2_REENTRY_QUEUE.md H1 row: change "issue #199 sub-track" → "issue #374".

Why

#199 was the enforcement-triad umbrella. Per ratified spec docs/v2_enforcement.md (PR #257):

#199 closed as the umbrella resolves into the splits. The queue's H1 row was pointing at the now-closed umbrella; this PR points it at the live deferral issue (#374) so the audit trail stays correct.

Verify

  • grep -n '199 sub-track\|#374' docs/V2_REENTRY_QUEUE.md → only the new #374 line should appear.
  • Spec memo at docs/v2_enforcement.md (unchanged) is the source of truth for the disposition.

Tracks: #199, #373, #374.

Summary by Sourcery

Documentation:

Summary by CodeRabbit

  • Documentation
    • Updated internal tracking references and documentation structure.

#199 split into #373 (H3, ships at v2.0) and #374 (H1, deferred bench-gated)
per docs/v2_enforcement.md. H2 dropped per spec § H2. Update the H1 queue
row from "issue #199 sub-track" to the actual issue (#374) so the queue
links to a live tracking issue rather than the closed umbrella.
@sourcery-ai

sourcery-ai Bot commented May 3, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates documentation to point the enforcement H1 directive detection row at the correct, live GitHub issue (#374) instead of the closed umbrella issue (#199).

File-Level Changes

Change Details Files
Retarget the enforcement H1 directive detection queue entry to the correct split issue. docs/V2_REENTRY_QUEUE.md

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@yoshi280 yoshi280 added the attn:review Needs review (PR open, awaiting reviewer) label May 3, 2026
@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Documentation update to docs/V2_REENTRY_QUEUE.md where the Directive detection (enforcement H1) row reference is updated from issue #199 to issue #374. All supporting content remains unchanged.

Changes

Documentation Update

Layer / File(s) Summary
Issue Reference Update
docs/V2_REENTRY_QUEUE.md
Directive detection (enforcement H1) row reference changed from issue #199 to issue #374; spec linkage and disposition details remain intact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: updating the H1 row reference from issue #199 to #374 in the reentry queue documentation.
Description check ✅ Passed The description covers the 'What' and 'Why' sections comprehensively, provides a verification step, and references related issues. However, it does not follow the provided template structure with explicit sections like 'Linked issues', 'Type of change', or 'Verification' checkboxes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/issue-199-split-queue-link

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
docs/V2_REENTRY_QUEUE.md (1)

30-34: 💤 Low value

Minor wording consistency check (optional).

Line 31 clarifies “H3 selective injection ships at v2.0; H2 compliance audit is dropped, not deferred.” If that statement was authored for the prior #199 tracking context, it’s worth confirming it still matches what #374 tracks (it currently reads consistent, but this is easy to accidentally drift over time).

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/V2_REENTRY_QUEUE.md` around lines 30 - 34, The sentence stating “H3
selective injection ships at v2.0; H2 compliance audit is dropped, not
deferred.” may have been written for a different tracking issue (`#199`); verify
that it accurately reflects the current tracking issue (`#374`) and update the
wording to reference the correct tracking context or issue number (or remove the
issue-specific reference) so the statement remains consistent with what `#374`
tracks—locate the sentence in docs/V2_REENTRY_QUEUE.md (the quoted fragment) and
either correct the issue number or make the statement issue-agnostic.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@docs/V2_REENTRY_QUEUE.md`:
- Around line 30-34: The sentence stating “H3 selective injection ships at v2.0;
H2 compliance audit is dropped, not deferred.” may have been written for a
different tracking issue (`#199`); verify that it accurately reflects the current
tracking issue (`#374`) and update the wording to reference the correct tracking
context or issue number (or remove the issue-specific reference) so the
statement remains consistent with what `#374` tracks—locate the sentence in
docs/V2_REENTRY_QUEUE.md (the quoted fragment) and either correct the issue
number or make the statement issue-agnostic.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fa6c9a15-84f5-4852-a848-e40a8b3bf113

📥 Commits

Reviewing files that changed from the base of the PR and between a996dce and aa1aabb.

📒 Files selected for processing (1)
  • docs/V2_REENTRY_QUEUE.md

@yoshi280

yoshi280 commented May 3, 2026

Copy link
Copy Markdown
Collaborator Author

[claim:review:kulili:2026-05-03T15:56:42Z]

@robotrocketscience
robotrocketscience merged commit aa1aabb into main May 3, 2026
24 of 30 checks passed
@robotrocketscience
robotrocketscience deleted the docs/issue-199-split-queue-link branch May 3, 2026 15:57
@yoshi280

yoshi280 commented May 3, 2026

Copy link
Copy Markdown
Collaborator Author

[release:review:kulili:2026-05-03T15:57:11Z]

@yoshi280

yoshi280 commented May 3, 2026

Copy link
Copy Markdown
Collaborator Author

[claim:review:Gylf:2026-05-03T15:57:37Z]

@yoshi280 yoshi280 removed the attn:review Needs review (PR open, awaiting reviewer) label May 3, 2026
@yoshi280

yoshi280 commented May 3, 2026

Copy link
Copy Markdown
Collaborator Author

[release:review:Gylf:2026-05-03T15:58:15Z]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants