Skip to content

ci: SHA-pin third-party actions in #325 bundle workflows (closes #331) - #338

Merged
robotrocketscience merged 1 commit into
mainfrom
ci/issue-331-sha-pin-bundle-actions
May 1, 2026
Merged

ci: SHA-pin third-party actions in #325 bundle workflows (closes #331)#338
robotrocketscience merged 1 commit into
mainfrom
ci/issue-331-sha-pin-bundle-actions

Conversation

@robotrocketscience

@robotrocketscience robotrocketscience commented May 1, 2026

Copy link
Copy Markdown
Owner

Summary

SHA-pins all third-party GitHub Actions in the 6 bundle workflows added in #325, matching the pattern from #326 (step-security/harden-runner).

Pins applied

Action SHA Tag
step-security/harden-runner 8d3c67de8e2fe68ef647c8db1e6a09f647780f40 v2.19.0
crate-ci/typos (was @master) bbaefadf97b0ec5fdc942684b647f1a6ab250274 v1.46.0
astral-sh/setup-uv d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 v5.4.2
lycheeverse/lychee-action 8646ba30535128ac92d33dfc9133794bfdd9b411 v2.8.0
peter-evans/create-issue-from-file e8ef132d6df98ed982188e460ebb3b5d4ef3a9cd v5.0.1

First-party actions (actions/*, github/codeql-action/*) left at floating major tags per the #326 convention.

Files touched

.github/workflows/{typos,deadcode,zizmor,mutation,link-check,codeql}.yml

crate-ci/typos@master was the worst offender — branch tag, fully mutable. Now pinned to a real release.

Closes #331.

Summary by Sourcery

CI:

  • Update bundle workflows (typos, deadcode, zizmor, mutation, link-check, codeql) to use SHA-pinned versions of third-party GitHub Actions instead of floating tags.

Replaces floating versioned tags (`@v2`, `@v5`, `@master`) with full
40-char commit SHAs and a `# v<x.y.z>` comment for human readability.
Same convention as #326 applied to the 6 workflows added in #325:
`typos.yml`, `deadcode.yml`, `zizmor.yml`, `mutation.yml`,
`link-check.yml`, `codeql.yml`.

`crate-ci/typos@master` (worst offender — branch tag) is now pinned
to v1.46.0. First-party actions (`actions/*`, `github/codeql-action/*`)
keep floating major tags per the #326 pattern.

Closes #331.
@coderabbitai

coderabbitai Bot commented May 1, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@robotrocketscience has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes and 48 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9b2a8d76-c2e9-4528-9e1c-dcc2f0601077

📥 Commits

Reviewing files that changed from the base of the PR and between cbbbcf5 and aba8bed.

📒 Files selected for processing (6)
  • .github/workflows/codeql.yml
  • .github/workflows/deadcode.yml
  • .github/workflows/link-check.yml
  • .github/workflows/mutation.yml
  • .github/workflows/typos.yml
  • .github/workflows/zizmor.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/issue-331-sha-pin-bundle-actions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 50 minutes and 48 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sourcery-ai

sourcery-ai Bot commented May 1, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pins all third-party GitHub Actions used in six bundle workflows to specific commit SHAs, replacing floating tags (including one branch reference) while leaving first-party actions on floating major tags per project convention.

File-Level Changes

Change Details Files
Pin step-security/harden-runner to a specific SHA across all bundle workflows.
  • Replace step-security/harden-runner@v2 with step-security/harden-runner@8d3c67d in each job that previously used the v2 tag
  • Add inline comments documenting the corresponding released version (v2.19.0) next to each pin
.github/workflows/deadcode.yml
.github/workflows/link-check.yml
.github/workflows/mutation.yml
.github/workflows/typos.yml
.github/workflows/zizmor.yml
.github/workflows/codeql.yml
Pin astral-sh/setup-uv to a specific SHA in workflows that use it.
  • Replace astral-sh/setup-uv@v5 with astral-sh/setup-uv@d4b2f3b in deadcode, mutation, and zizmor workflows
  • Add inline comments indicating the pinned release version (v5.4.2) next to each use
.github/workflows/deadcode.yml
.github/workflows/mutation.yml
.github/workflows/zizmor.yml
Pin crate-ci/typos action to a stable release SHA instead of a mutable branch reference.
  • Replace crate-ci/typos@master with crate-ci/typos@bbaefad in the typos workflow
  • Add an inline comment documenting the pinned release version (v1.46.0)
.github/workflows/typos.yml
Pin lycheeverse/lychee-action and peter-evans/create-issue-from-file to specific SHAs in the link-check workflow. .github/workflows/link-check.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#331 Replace all floating third-party action versions (including branch tags like crate-ci/typos@master) in the 6 listed workflows with 40-character commit SHAs, while keeping first-party actions (actions/, github/codeql-action/) on floating major tags.
#331 Add a human-readable version comment (e.g., # v<x.y.z>) next to each newly SHA-pinned third-party action in the 6 workflows.
#331 Ensure the crate-ci/typos@master reference is removed from typos.yml and replaced with a pinned commit SHA.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@robotrocketscience robotrocketscience added the author-Kulili PR coordination mutex label May 1, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@robotrocketscience

Copy link
Copy Markdown
Owner Author

[claim:review:Gylf:2026-05-01T16:05:03Z]

@robotrocketscience
robotrocketscience merged commit aba8bed into main May 1, 2026
18 of 24 checks passed
@robotrocketscience
robotrocketscience deleted the ci/issue-331-sha-pin-bundle-actions branch May 1, 2026 16:05
@robotrocketscience

Copy link
Copy Markdown
Owner Author

[release:review:Gylf:2026-05-01T16:05:25Z]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author-Kulili PR coordination mutex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: SHA-pin third-party actions in #325 bundle workflows

1 participant