Skip to content

chore: remove unused CORROBORATION_SOURCE_HOOK_INGEST #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robotrocketscience merged 1 commit into from
May 2, 2026
Merged

chore: remove unused CORROBORATION_SOURCE_HOOK_INGEST #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/aelfrice/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@
CORROBORATION_SOURCE_COMMIT_INGEST: Final[str] = "commit_ingest"
CORROBORATION_SOURCE_TRANSCRIPT_INGEST: Final[str] = "transcript_ingest"
CORROBORATION_SOURCE_MCP_REMEMBER: Final[str] = "mcp_remember"
CORROBORATION_SOURCE_HOOK_INGEST: Final[str] = "hook_ingest"
# filesystem_ingest: scanner / onboard paths that read local files
# (not git history). Distinct from transcript_ingest (conversation
# turns) and commit_ingest (git history).
Expand All @@ -100,7 +99,6 @@
CORROBORATION_SOURCE_COMMIT_INGEST,
CORROBORATION_SOURCE_TRANSCRIPT_INGEST,
CORROBORATION_SOURCE_MCP_REMEMBER,
CORROBORATION_SOURCE_HOOK_INGEST,
CORROBORATION_SOURCE_FILESYSTEM_INGEST,
CORROBORATION_SOURCE_CLI_REMEMBER,
CORROBORATION_SOURCE_CONSOLIDATION_MIGRATION,
Expand Down
8 changes: 2 additions & 6 deletions tests/test_corroborations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from aelfrice.models import (
BELIEF_FACTUAL,
CORROBORATION_SOURCE_COMMIT_INGEST,
CORROBORATION_SOURCE_HOOK_INGEST,
CORROBORATION_SOURCE_MCP_REMEMBER,
CORROBORATION_SOURCE_TRANSCRIPT_INGEST,
CORROBORATION_SOURCE_TYPES,
Expand Down Expand Up @@ -249,19 +248,17 @@ def test_different_source_types_record_distinctly() -> None:
store.record_corroboration("b1", source_type=CORROBORATION_SOURCE_TRANSCRIPT_INGEST)
store.record_corroboration("b1", source_type=CORROBORATION_SOURCE_COMMIT_INGEST)
store.record_corroboration("b1", source_type=CORROBORATION_SOURCE_MCP_REMEMBER)
store.record_corroboration("b1", source_type=CORROBORATION_SOURCE_HOOK_INGEST)

assert store.count_corroborations("b1") == 4
assert store.count_corroborations("b1") == 3

rows = store.list_corroborations("b1")
assert len(rows) == 4
assert len(rows) == 3
# rows are (ingested_at, source_type, session_id, source_path_hash)
recorded_types = {r[1] for r in rows}
assert recorded_types == {
CORROBORATION_SOURCE_TRANSCRIPT_INGEST,
CORROBORATION_SOURCE_COMMIT_INGEST,
CORROBORATION_SOURCE_MCP_REMEMBER,
CORROBORATION_SOURCE_HOOK_INGEST,
}
finally:
store.close()
Expand All @@ -277,7 +274,6 @@ def test_source_type_enum_covers_all_variants() -> None:
"commit_ingest",
"transcript_ingest",
"mcp_remember",
"hook_ingest",
"filesystem_ingest",
"cli_remember",
"consolidation_migration",
Expand Down
Loading