docs: audit aelfrice hook injection (refs #220) - #278
Merged
Conversation
Audit + characterisation of the two hook paths that inject aelfrice belief context into live sessions: UserPromptSubmit (per-prompt) and PreToolUse on Grep/Glob (per-tool-call). No code changes. Documents query construction, retrieval layers invoked, token budgets, relevance-filter mismatch, corpus-path resolution, and proposes three bounded tuning recommendations. Supersedes the previous PR #268 branch which carried an unrelated private project codename in two lines and could not pass history-scan even after the codename was redacted from the tip. Closes #220.
Owner
Author
|
Review: nearly clean — one fixup needed. Line numbers drift in the recommendations against current
Looks like the audit was written against installed package line numbers ( Otherwise: technical claims hold (verified Push the line-number fix and this is mergeable. Dropping review label. |
8 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit + characterisation of the two hook paths that inject aelfrice belief context into live sessions: UserPromptSubmit (per-prompt) and PreToolUse on Grep/Glob (per-tool-call). No code changes; the doc proposes three bounded tuning recommendations.
Replaces the previous PR (#268) which had an unrelated private project codename baked into one of its commits; even after redaction at tip, scoped history-scan still saw it in the PR's incoming range. This branch starts from main with one clean commit.
Closes #220. Refs #272.