feat: bulk= keyword param on ingest_turn (#194) - #276
Merged
Conversation
Additive, keyword-only `bulk: bool = False` on `ingest_turn` for research-line / batch ingest callers (e.g. wonder_ingest). When True, duplicate-sentence corroboration writes are skipped — the only currently-redundant per-turn side effect. Canonical beliefs row and v2.0 ingest_log row always produced; final belief state is identical either way. Default-off preserves prior behaviour for all existing callers. Closes #194.
robotrocketscience
force-pushed
the
feat/issue-194-ingest-bulk-param
branch
from
April 29, 2026 01:04
3274411 to
56cad93
Compare
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Additive, keyword-only
bulk: bool = Falseoningest_turn.When
bulk=True, duplicate-sentencerecord_corroborationwrites are skipped — the only currently-redundant per-turn side effect inside a multi-turn batch. Canonicalbeliefsrow and v2.0ingest_logrow are always produced; final belief state is identical either way.Default-off preserves prior behaviour for every existing caller.
Scope decisions
bulkis keyword-only (positional pass rejected) — guards against future args being inserted before it and keeps the call site self-documenting.record_corroborationon duplicates). Docstring notes it's reserved for future per-turn-cost reductions as new side effects land.flush()/ context-manager — there is nothing buffered to flush at present. SQLite autocommit at the store layer is fine for current scale.Tests
tests/test_ingest_bulk.py(new):bulk=Truevsbulk=Falsebeliefs, divergentbelief_corroborationsbulk=Truestill writesingest_log(v2.0 source-of-truth invariant)Full local run: 1728 passed, 8 skipped.
Closes #194.