Skip to content

add support for bordered in a PopUpButton and a list2 PopUpButton #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024
Merged

add support for bordered in a PopUpButton and a list2 PopUpButton #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/vanilla/vanillaList2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,11 +1316,13 @@ class PopUpButtonList2Cell(PopUpButton):
def __init__(self,
items=[],
editable=False,
callback=None
callback=None,
bordered=False,
):
super().__init__(
"auto",
items=items,
bordered=bordered,
sizeStyle="small",
callback=callback
)
Expand Down
6 changes: 3 additions & 3 deletions Lib/vanilla/vanillaPopUpButton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,15 @@ def popUpButtonCallback(self, sender):
"regular": (-3, -4, 6, 6),
}

def __init__(self, posSize, items, callback=None, sizeStyle="regular"):
def __init__(self, posSize, items, callback=None, sizeStyle="regular", bordered=True):
self._setupView(self.nsPopUpButtonClass, posSize)
if self.nsPopUpButtonCellClass != NSPopUpButtonCell:
self._nsObject.setCell_(self.nsPopUpButtonCellClass.alloc().init())
if callback is not None:
self._setCallback(callback)
self._setSizeStyle(sizeStyle)
self.setItems(items)
self._nsObject.setBordered_(bordered)

def getNSPopUpButton(self):
"""
Expand Down Expand Up @@ -212,10 +213,9 @@ def subFirstCallback(self, sender):
"""

def __init__(self, posSize, items, sizeStyle="regular", bordered=True):
super().__init__(posSize, items, sizeStyle=sizeStyle)
super().__init__(posSize, items, sizeStyle=sizeStyle, bordered=bordered)
self._nsObject.setPullsDown_(True)
self._nsObject.setBezelStyle_(NSTexturedRoundedBezelStyle)
self._nsObject.setBordered_(bordered)

def _breakCycles(self):
self._menuItemCallbackWrappers = None
Expand Down