FindOrBuildPackage: Do not run find_package if YCM_DISABLE_SYSTEM_PACKAGES is ON #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…KAGES is ON
In FindOrBuildPackage a preliminary `find_package` is run to decide if it make sense to provide to the
user the `USE_SYSTEM_${_PKG}` option. However if `YCM_DISABLE_SYSTEM_PACKAGES` is ON, the
`USE_SYSTEM_${_PKG}` option is already disabled, so we can skip the `find_package` calls.
This was referenced Apr 13, 2022
|
I tested locally in a WSL2 instance, and this PR reduce the CMake configuration from 42 seconds (top) to 12 seconds (bottom): |
|
The test in robotology/robotology-superbuild#1093 were successful. |
RiccardoGrieco
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FindOrBuildPackage a preliminary
find_packageis run to decide if it make sense to provide to theuser the
USE_SYSTEM_${_PKG}option. However ifYCM_DISABLE_SYSTEM_PACKAGESis ON, theUSE_SYSTEM_${_PKG}option is already disabled, so we can skip thefind_packagecalls.This change should dramatically reduce the CMake configuration for superbuilds in which
YCM_DISABLE_SYSTEM_PACKAGESis ON and that have many subpackages.