Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import FindOctave version of it in the wild #193

Closed
traversaro opened this issue Dec 29, 2018 · 2 comments
Closed

Import FindOctave version of it in the wild #193

traversaro opened this issue Dec 29, 2018 · 2 comments

Comments

@traversaro
Copy link
Member

A FindOctave.cmake was added in https://gitlab.kitware.com/cmake/cmake/merge_requests/2630 to CMake upstream. We can check if that one is compatible with the version that we ship, and eventually import that one via cmake-next to remove the 3rdparty/cmake-wiki directory.
@weekly-digest weekly-digest bot mentioned this issue Dec 30, 2018
Closed
drdanz added a commit to drdanz/ycm that referenced this issue Jan 7, 2019
@drdanz
cmake-next/3rd-party: Import FindOctave from CMake master instead of …
190e7f1 
…cmake wiki

Fixes robotology#193
@drdanz drdanz mentioned this issue Jan 7, 2019
Closed
drdanz added a commit to drdanz/ycm that referenced this issue Jan 7, 2019
@drdanz
cmake-next/3rd-party: Import FindOctave from CMake master instead of …
e62cd3a 
…cmake wiki

Fixes robotology#193
drdanz added a commit to drdanz/ycm that referenced this issue Feb 26, 2019
@drdanz
cmake-next/3rd-party: Import FindOctave from CMake master instead of …
b13e17c 
…cmake wiki

Fixes robotology#193
@drdanz drdanz mentioned this issue Mar 15, 2019
Closed
5 tasks
@traversaro
Copy link
Member Author

traversaro commented Apr 21, 2020 •
edited by unfurl-links bot
Loading

It turns our that in the end FindOctave was never included in CMake upstream: https://gitlab.kitware.com/cmake/cmake/-/issues/18988 .

GitLab
On my system (debian testing + CMake master) the `FindOctave` module sets the `Octave_INCLUDE_DIR` to `/usr/include/octave-4.4.1/octave`. This folder should be `/usr/include/octave-4.4.1` instead. The same issue is inherited by the `Octave::Octave`...

@traversaro traversaro mentioned this issue Apr 21, 2020
Merged
@traversaro traversaro changed the title Import FindOctave from CMake upstream Import FindOctave version of it in the wild Jan 13, 2021
@traversaro
Copy link
Member Author

Closing as FindOctave is not part of upstream CMake, so it is not clear what the definition of done of this issue would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@traversaro