Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to set a different frequency for each sensor #40

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

GiulioRomualdi
Copy link
Member

Thanks to this PR it will be possible to set different frequencies for each sensor exposed in the device. To do that I:

  • removed the polling thread and used the callback provided by xsens to get the data
  • Add optional parameters to specifically set the period of each sensor exposed by the IMU. If the parameter is not passed the xsensmt_period is used. This means that this implementation is retro compatible with the already existing configuration files
  • I updated the readme

cc @traversaro @HosameldinMohamed

README.md Outdated
##### Device use
## Device use

### Via `inertial` network device (Deprecated)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is deprecated, can you move it at the bottom? Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Can you add a line in the CHANGELOG?

@GiulioRomualdi
Copy link
Member Author

Minor comment. Can you add a line in the CHANGELOG?

Done

@traversaro traversaro merged commit 7a2de59 into robotology:master Mar 24, 2023
@GiulioRomualdi GiulioRomualdi deleted the multiple_frequencies branch March 24, 2023 12:03
@HosameldinMohamed
Copy link
Contributor

  • removed the polling thread and used the callback provided by xsens to get the data

Thanks, @GiulioRomualdi for this! I will later add the position support to the MAS interface according to #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants