Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding setLanguage at runtime #36

Merged
merged 8 commits into from
May 20, 2021
Merged

Adding setLanguage at runtime #36

merged 8 commits into from
May 20, 2021

Conversation

vtikha
Copy link
Member

@vtikha vtikha commented May 20, 2021

This PR adds the possibility to change the language at run time. for both googleSpeech and googleDialog

The user is now able to modify the language through the following rpc command.

Example of the language switch:

setLanguage en-US

by default, the language and voice codes currently supported are the following, but can be easily extended by adding the required entries in the config.ini

languageCodes     en-US it-IT pt-PT fr-FR en-GB

Here is a list of the possible extra interaction with the module

setLanguage(1:string languageCode);
getLanguageCode();

@vtikha vtikha self-assigned this May 20, 2021
@vtikha vtikha marked this pull request as ready for review May 20, 2021 13:57
Copy link
Contributor

@lauracavaliere lauracavaliere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes seem correct to me! Thank you @vtikha !

Copy link
Contributor

@ilaria-carlini ilaria-carlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtikha! It looks good to me, too.

@Nicogene Nicogene merged commit f0e4494 into master May 20, 2021
@Nicogene Nicogene deleted the vtikha-patch-1 branch May 20, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants