Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

googleSynthesis with external audio stream #33

Merged
merged 2 commits into from
Apr 22, 2022
Merged

googleSynthesis with external audio stream #33

merged 2 commits into from
Apr 22, 2022

Conversation

randaz81
Copy link
Member

  • googleSynthesis can now stream audio to an external player.

  • added the parameter --playbackmode which can assume the values playFromDisk (default), sendToPort_compressed, sendToPort_uncompressed

@pattacini pattacini requested a review from vtikha March 23, 2021 14:28
@randaz81
Copy link
Member Author

randaz81 commented Mar 23, 2021 •
edited
Loading

@vtikha The module compiles only with yarp master branch (future yarp 3.5).

So better not to merge this PR into master, if your master branch is supposed to work with yarp 3.4.
Maybe a devel branch (not available for this repository) is more appropriate?

@pattacini
Copy link
Member

We can merge it anyway and rely on the releases to get more stable versions of the code.

@randaz81 randaz81 force-pushed the gs_external_stream branch from e295743 to 27c87b4 Compare March 23, 2021 14:31
@pattacini
Copy link
Member

pattacini commented Mar 23, 2021 •
edited
Loading

Well, with a second thought, this might cause problems @randaz81.
Even forging devel won't work as new devs we're doing will land there and should be working w/ yarp < 3.5.

You can use your fork until YARP 3.5 will become official. This is the easiest solution.

@randaz81 randaz81 force-pushed the gs_external_stream branch from 27c87b4 to 1d3722e Compare April 15, 2021 09:37
@randaz81
Copy link
Member Author

PR rebased onto master

@randaz81 randaz81 force-pushed the gs_external_stream branch from 1d3722e to 3b123c0 Compare May 20, 2021 16:30
@randaz81 randaz81 force-pushed the gs_external_stream branch from 3b123c0 to f30e6bd Compare June 14, 2021 15:46
@randaz81 randaz81 force-pushed the gs_external_stream branch from f70495b to 6d20fb9 Compare March 30, 2022 12:15
@randaz81
Copy link
Member Author

PR rebased onto master

@pattacini
Copy link
Member

Our latest distro relies on YARP-3.6.0, thus it should be fine now to proceed with the review @vtikha.

@randaz81
Copy link
Member Author

@pattacini @vtikha we are using yarp> 3.5 so I think that there are no more issues, can we merge this?

vtikha
vtikha approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@vtikha vtikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtikha vtikha merged commit a014da9 into robotology:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtikha vtikha vtikha approved these changes

Assignees

@randaz81 randaz81

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@randaz81 @pattacini @vtikha @DatSpace