Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speechInteraction: cleanup of cmake #31

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Conversation

Nicogene
Copy link
Member

This is for making it cross platform

Moreover added some dependencies via FetchContent, google speech api has still to be fixed

Copy link
Member

@vtikha vtikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (so far)!

@Nicogene Nicogene marked this pull request as ready for review March 2, 2021 16:17
@Nicogene
Copy link
Member Author

Nicogene commented Mar 2, 2021

I redimensioned the PR, the google API needs grpc installed in the system if using the makefile specified in the repo, or its clone and install its own if using Bazel(see https://github.com/googleapis/googleapis#building). The FetchContent has not so much sense in this case.
I left the part about googleapis untouched, since to me seems not super cmake-friendly(in fact they support and use Bazel) and I didn't find a better way to include it
In any case, now the libraries are linked as cmake targets and it is a step in the direction of making it cross-platform.

@vtikha vtikha merged commit a3c2d5b into robotology:master Mar 3, 2021
@Nicogene Nicogene deleted the fix/Cmake branch March 4, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants