Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sync port #30

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Added sync port #30

merged 2 commits into from
Nov 2, 2020

Conversation

Iaxama
Copy link
Contributor

@Iaxama Iaxama commented Nov 2, 2020

No description provided.

@vtikha
Copy link
Member

vtikha commented Nov 2, 2020

Ciao @Iaxama, can you add the closing of the port?

@Iaxama
Update main.cpp
29b3a7b 
closing port
@Iaxama
Copy link
Contributor Author

Iaxama commented Nov 2, 2020

Ciao @Iaxama, can you add the closing of the port?

done

@vtikha vtikha merged commit f3f3dab into robotology:master Nov 2, 2020
pattacini
pattacini reviewed Nov 2, 2020
View reviewed changes
speechInteraction/modules/googleSynthesis/main.cpp
}

/********************************************************/
void onRead( yarp::os::Bottle &bot )
{
queryGoogleSynthesis(bot);
yarp::os::Bottle syncBot;
syncBot.addString("done");
syncBot.write(syncBot);
Copy link
Member

@pattacini pattacini Nov 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Iaxama is a standard port the one you really need here?

In pretty much all the cases a BufferPort::write() does a better job than Port::write() as the former will prevent the module from being stuck upon waiting that the receiver will have called the corresponding read().

cc @vtikha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattacini pattacini pattacini left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Iaxama @vtikha @pattacini