-
Notifications
You must be signed in to change notification settings - Fork 50
Add gz-sim-yarp-plugins package #1628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gz-sim-yarp-plugins package #1628
Conversation
@traversaro I was looking how to enable the build of Should I configure an additional step similar to robotology-superbuild/.github/workflows/ci.yml Lines 384 to 391 in 5737298
with the |
Ah, this thing of mutual exclusivity is complex and is going to be an headache. Until now, the logic in the CI was always: "just enable everything". Now I guess we need either to:
Feel free to follow the path that make more sense to you, probably the second one is easier. |
@traversaro in robotology-superbuild/doc/conda-forge.md Lines 181 to 201 in 5737298
CMAKE_INSTALL_PREFIX variable should be set to CONDA_PREFIX . Is it on purpose?
|
The superbuild is a bit special, as it does not have any install step. In its |
Ok it's clear now thanks! |
This comment was marked as resolved.
This comment was marked as resolved.
@traversaro should I add the environment variable |
Yes. Eventually we will add gz-sim support there, so let's already do it so we can forget about this. |
Note that probably given all the problems related to co-installation of gz-sim and gazebo-classic we can skip the CI part for now. |
I left a bunch of comments, but the gist is the following: never use "Gazebo" without specification, it is going to be too confusing otherwise for users that called "Classic Gazebo" Gazebo for years. |
Ok, what term we should use for new Gazebo? Modern Gazebo or gz-sim? |
Co-authored-by: Silvio Traversaro <[email protected]>
4e51d08
to
795dfdc
Compare
I tested the usage of |
Thanks, I think we can proceed with merging. Existing conda users may need to pay attention as now |
Yep exactly, now Sure, squeeze! 🧽 |
This PR adds the https://github.com/robotology/gz-sim-yarp-plugins package.
Reference issue: robotology/gz-sim-yarp-plugins#131