Skip to content

Build qhull only on Ubuntu 20.04 #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traversaro merged 7 commits into from
Mar 2, 2023
Merged

Build qhull only on Ubuntu 20.04 #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
896f6a6
Never build qhull
traversaro Feb 20, 2023
63154fd
Update ProjectsTagsStable.cmake
traversaro Feb 27, 2023
8cb85a3
Create Buildqhull.cmake
traversaro Feb 27, 2023
ab99148
Update RobotologySuperbuildLogic.cmake
traversaro Feb 27, 2023
eea29d4
Update ProjectsTagsStable.cmake
traversaro Feb 28, 2023
137a43e
Update RobotologySuperbuildLogic.cmake
traversaro Feb 28, 2023
46ef9f0
Update RobotologySuperbuildLogic.cmake
traversaro Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apt.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ qtbase5-dev
qtdeclarative5-dev
qtmultimedia5-dev
libqt5opengl5-dev
libqhull-dev
swig
libmatio-dev
libirrlicht-dev
Expand Down
17 changes: 15 additions & 2 deletions cmake/RobotologySuperbuildLogic.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,25 @@ else()
set(ROBOTOLOGY_CONFIGURING_UNDER_CONDA OFF)
endif()

# We only build qhull on Linux, not on conda, Windows or macOS

# We only build qhull on Ubuntu 20.04, not on any other platform
# See https://github.com/robotology/robotology-superbuild/issues/1269#issuecomment-1257811559
# See https://stackoverflow.com/questions/26919334/detect-underlying-platform-flavour-in-cmake
if(ROBOTOLOGY_CONFIGURING_UNDER_CONDA OR APPLE OR WIN32)
set(ROBOTOLOGY_BUILD_QHULL OFF)
else()
set(ROBOTOLOGY_BUILD_QHULL ON)
find_program(ROBSUB_LSB_RELEASE lsb_release)
if(ROBSUB_LSB_RELEASE)
execute_process(COMMAND lsb_release -cs
OUTPUT_VARIABLE LSB_RELEASE_CODENAME
OUTPUT_STRIP_TRAILING_WHITESPACE
)
endif()
if(LSB_RELEASE_CODENAME STREQUAL "focal")
set(ROBOTOLOGY_BUILD_QHULL ON)
else()
set(ROBOTOLOGY_BUILD_QHULL OFF)
endif()
endif()

# Core
Expand Down