Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect tags for 2020.02 release #331

Closed
traversaro opened this issue Jan 20, 2020 · 29 comments
Closed

Collect tags for 2020.02 release #331

traversaro opened this issue Jan 20, 2020 · 29 comments

Comments

@traversaro
Copy link
Member

traversaro commented Jan 20, 2020

Hi everyone, in particular maintainers of the components of the robotology-superbuild and of the projects contained in the robotology-superbuild. As discussed in robotology/community#377 (comment), there is the plan of creating a "distribution" release for the software contained in the robotology-superbuild every three months.

The next planned release is the 2020.02, tentatively planned for the mid of February. For this reason, I would like to start collecting the set of (compatibile) releases of the software contained in the robotology-superbuild that could be used for this 2020.02 release, to provide a specific ProjectTags.cmake file, as for example was proposed in #318 . If you mantain any of the software listed in the following, feel free to comment on this issue to propose an already released version of the software that could be include in the 2020.02 distribution release. Even if the release is not done yet, but you still plan to do a release before February 2020, feel free to comment, thanks!

Proposed tags for 2020.02 :

# External projects
set_tag(qpOASES_TAG v3.2.0.1)
set_tag(osqp_TAG v0.6.0)

# Core profile 
set_tag(YARP_TAG v3.3.2)
set_tag(ICUB_TAG v1.15.0)
set_tag(ICUBcontrib_TAG v1.15.0)
set_tag(icub-models_TAG v1.15.0)
set_tag(robots-configuration_TAG v1.15.0)
set_tag(GazeboYARPPlugins_TAG v3.3.0)
set_tag(icub-gazebo_TAG v1.15.0)
set_tag(yarp-matlab-bindings_TAG v3.3.0)

# Robot Testing 
set_tag(RobotTestingFramework_TAG v2.0.0)
set_tag(icub-tests_TAG v1.15.0)

# Dynamics 
set_tag(iDynTree_TAG v1.0.1)
set_tag(wholeBodyInterface_TAG v0.2.6)
set_tag(yarpWholeBodyInterface_TAG v0.3.6)
set_tag(codyco-modules_TAG v0.3.0)
set_tag(BlockFactory_TAG v0.8.1)
set_tag(WBToolbox_TAG v5)
set_tag(OsqpEigen_TAG v0.5.2)
set_tag(UnicyclePlanner_TAG v0.2.0)
set_tag(walking-controllers_TAG v0.2.1)
set_tag(icub-gazebo-wholebody_TAG v0.1.0)
set_tag(whole-body-controllers_TAG v2.0)

# Teleoperation
set_tag(walking-teleoperation_TAG v0.2.0)

# Human Dynamics 
set_tag(forcetorque-yarp-devices_TAG v0.2.0)
set_tag(wearables_TAG v1.0.0)
set_tag(human-dynamics-estimation_TAG v2.0.0)
set_tag(human-gazebo_TAG v1.0)

# iCub Head
set_tag(icub-firmware-shared_TAG v1.15.0)
set_tag(xsensmt-yarp-driver_TAG v0.1.0)

# iCub Basic  Demos
set_tag(speech_TAG v1.0.0)
set_tag(icub-basic-demos_TAG v1.15.0)
set_tag(funny-things_TAG v1.0.0)
@traversaro
Copy link
Member Author

traversaro commented Jan 20, 2020

@S-Dafarra
Copy link
Collaborator

@traversaro
Copy link
Member Author

Ack. Note that the long patch version was used in YARP and iDynTree to indicate a development version, so if you see it fit feel free to bump the minor version.

@S-Dafarra
Copy link
Collaborator

Not sure I understood 😬

@traversaro
Copy link
Member Author

You released version 0.1.103 of the UnicyclePlanner, but that use of 103 as a patch number for iDynTree and YARP is used to indicate that that version is not a stable version, see https://github.com/robotology/yarp/blob/master/.github/CONTRIBUTING.md#terminology . So, if you like you can bump the version of UnicyclePlanner to 0.2.0, so it is clear that it is a stable release.

@S-Dafarra
Copy link
Collaborator

Ok, done and updated tag: https://github.com/robotology/unicycle-footstep-planner/releases/tag/v0.2.0

@traversaro
Copy link
Member Author

traversaro commented Jan 21, 2020

Missing tags (I mention who I presume is the maintainer of the relative repo, correct me if I am wrong):

@traversaro
Copy link
Member Author

cc @vtikha

@lrapetti
Copy link
Member

@traversaro
Copy link
Member Author

Given #124, we should also have tags for speech, icub-basic-demos and funny-things. cc @pattacini

@pattacini
Copy link
Member

@traversaro we normally tag icub-basic-demos already.
I'll be dealing with speech and funny-things then.

@yeshasvitirupachuri
Copy link
Member

yeshasvitirupachuri commented Jan 29, 2020

human-gazebo v1.0

HDE v2.0.0 - after the big code refactoring towards v2.0, we did not have any code on the master branch tagged for the release. This v2.0.0 tag is at the current devel branch, which is fully functional for demonstrating HDE and retargeting. Following the code clean up robotology/human-dynamics-estimation#101, minor releases can be done.

@traversaro @lrapetti @kouroshD

@traversaro
Copy link
Member Author

human-gazebo v1.0

HDE v2.0.0 - after the big code refactoring towards v2.0, we did not have any code on the master branch tagged for the release. This v2.0.0 tag is at the current devel branch, which is fully functional for demonstrating HDE and retargeting. Following the code clean up robotology/human-dynamics-estimation#101, minor releases can be done.

@traversaro @lrapetti @kouroshD

Thanks! If even releases such as v2.0.0 is based on the devel branch, what is the purpose of the master branch? To keep minor release of the 1.x series?

@yeshasvitirupachuri
Copy link
Member

@traversaro I think we will not be using master branch anymore. I remember there was an issue related to "stable" branch, can you please point to it. If I remember well the devel branch is considered the stable branch right ?

@diegoferigo
Copy link
Member

@Yeshasvitvs If the master branch is no longer used, I would just add a new v1.X to the last master commit, merge devel to master, and tag the v2.0.

Since now icub-tech changed considerably the release schedule and new versions are tagged more often, I start seeing less and less the need of a devel branch on many of our projects. HDE and wearables are among those.

@traversaro
Copy link
Member Author

. I remember there was an issue related to "stable" branch, can you please point to it.

Sorry, I am not really sure which issue are you referring to.

@lrapetti
Copy link
Member

lrapetti commented Jan 30, 2020

@Yeshasvitvs If the master branch is no longer used, I would just add a new v1.X to the last master commit, merge devel to master, and tag the v2.0.

I'm not sure but I think teleoperation guys are actually using master branch (or the branch that is being merged into master -> robotology/human-dynamics-estimation#164) since it is actually still more stable since devel branch has some dependency on non-stable branches of other repos.

Probably @kouroshD can confirm it.

@lrapetti
Copy link
Member

@Yeshasvitvs If the master branch is no longer used, I would just add a new v1.X to the last master commit, merge devel to master, and tag the v2.0.

I'm not sure but I think teleoperation guys are actually using master branch (or the branch that is being merged into master -> robotology/human-dynamics-estimation#164) since it is actually still more stable since devel branch has some dependency on non-stable branches of other repos.

Probably @kouroshD can confirm it.

sorry, I was confused, you can ignore my previous comment. master is actually deprecated and can be replaced by devel branch.

@yeshasvitirupachuri
Copy link
Member

If the master branch is no longer used, I would just add a new v1.X to the last master commit, merge devel to master, and tag the v2.0.

@diegoferigo master branch actually has the code of v2.0.

@yeshasvitirupachuri
Copy link
Member

Sorry, I am not really sure which issue are you referring to.

robotology/community#372

Sorry, I got confused with which is considered a stable branch. So, if I understood well:

  • devel branches are no longer used
  • master branch becomes the devel branch that will contain new features and is under active development
  • stable branches are version tagged

@traversaro please correct me if I am getting it wrong. Thanks!

@traversaro
Copy link
Member Author

Sorry, I am not really sure which issue are you referring to.

robotology/QA#372

Sorry, I got confused with which is considered a stable branch. So, if I understood well:

* `devel` branches are no longer used

* `master` branch becomes the devel branch that will contain new features and is under active development

* stable branches are version tagged

@traversaro please correct me if I am getting it wrong. Thanks!

That is the policy used by YCM and YARP, most of other repos remain on the older policy, i.e. :

  • master is the latest stable branches, on which new bug-fix releases are tagged
  • devel is the "unstable" branch in which new features are developed, and that is merged to master before a new release

For the repos you mantain, you are free to chose the branch policy that you prefer, at the moment master/devel is still the one most used in IIT's repos, but the one used by YARP has its own advantages.

@yeshasvitirupachuri
Copy link
Member

We will stick with the master/devel branch management. I rebased the master branch to devel and merged it. So, both the branches are aligned at the moment robotology/human-dynamics-estimation#101 (comment).

I created as new tag at the current master HDE v2.0.0. Please ignore the tag mentioned in #331 (comment)

@lrapetti @kouroshD

@traversaro
Copy link
Member Author

Thanks for the effort @Yeshasvitvs , @lrapetti and @kouroshD !

@traversaro
Copy link
Member Author

We will stick with the master/devel branch management. I rebased the master branch to devel and merged it. So, both the branches are aligned at the moment robotology/human-dynamics-estimation#101 (comment).

I created as new tag at the current master HDE v2.0.0. Please ignore the tag mentioned in #331 (comment)

@lrapetti @kouroshD

Unfortunately the CI revealed a critical bug that prevents compilation on Windows of that version (see robotology/human-dynamics-estimation#171), so it is not suitable to included iin 2020.02 . In general, it may be a good idea to keep a given software version in master or in devel for a short time to ensure that it works fine, before tagging a release.

@GiulioRomualdi
Copy link
Member

GiulioRomualdi commented Jan 31, 2020

@traversaro
I updated osqp-eigen tag. Now we can use this one https://github.com/robotology/osqp-eigen/releases/tag/v0.5.2

Notice this release is compatible with osqp 0.6.0

@nunoguedelha

@traversaro
Copy link
Member Author

At the moments we are just missing the tags:

Besides that, all the other repos should have the correct tags.

@traversaro
Copy link
Member Author

The icub-* repo has been tagged, and also walking-controllers has its valid release. Thanks to everyone that contributed!

traversaro added a commit that referenced this issue Feb 20, 2020
traversaro added a commit that referenced this issue Feb 20, 2020
traversaro added a commit that referenced this issue Feb 20, 2020
traversaro added a commit that referenced this issue Feb 20, 2020
traversaro added a commit that referenced this issue Feb 20, 2020
@traversaro
Copy link
Member Author

It turns out that there are some problems in the provided tags, see #352, specifically in human-dynamics-estimation and iDynTree.

@kouroshD @traversaro @lrapetti can you please add a new tag? Thanks!

@traversaro
Copy link
Member Author

The new 2020.02 is finally completed in https://github.com/robotology/robotology-superbuild/releases/tag/v2020.02 . Feel free to test it either by checking out the v2020.02 tag, or using the Windows binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants