Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MATLAB installation instructions for whole-body-controllers #202

Closed
traversaro opened this issue May 6, 2019 · 9 comments
Closed
Assignees

Comments

@traversaro
Copy link
Member

Recently whole-body-controllers added some installation steps (see https://github.com/robotology/whole-body-controllers#installation-and-usage), that are not mentioned nor referenced in the MATLAB instructions:
https://github.com/robotology/robotology-superbuild#matlab .

We should update the section to either explain what to do or link the relevant documentation.

@traversaro traversaro changed the title Update MATLAB installation instructions Update MATLAB installation instructions for whole-body-controllers May 6, 2019
@gabrielenava gabrielenava self-assigned this Jul 1, 2019
@gabrielenava
Copy link
Collaborator

Entry point to WBC documentation added with #229

In this specific case I think that the user that is interested in installing whole-body-controllers should read the associated README and documentation, that will be the only one mantained and updated. Therefore I prefer to provide an entry point to the WBC README rather than duplicate the info in the robotology-superbuild readme.

@traversaro
Copy link
Member Author

I do not know. While I guess that you need to read the docs for each repo you want to actually use, having manual installation steps for single subprojects seems to defeat the purpose of having a superbuild at all. I need to think a bit about a proper trade-off.

@traversaro
Copy link
Member Author

I did not have time to work on a better solution, so for the time being let's just merge your docs, and if in the future we want to improve this we can always do that.

@traversaro
Copy link
Member Author

@gabrielenava Is this related to robotology/whole-body-controllers#75 ?

@gabrielenava
Copy link
Collaborator

Yes, there are some on going modifications in whole-body-controllers concerning the installation of the repo. I will handle all these issues.

@gabrielenava
Copy link
Collaborator

I think the latest WBC release removed the necessity of extra installation steps for the repo: https://github.com/robotology/whole-body-controllers#installation-and-usage.

@traversaro
Copy link
Member Author

Great, so I guess we can close this issue? There is something to update in the README?

@gabrielenava
Copy link
Collaborator

gabrielenava commented Apr 25, 2020

I already updated the robotology superbuild readme when releasing WBC 2.5. We can close the issue :-)

@traversaro
Copy link
Member Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants